feat(alerts): add artist series to initial criteria for artwork-based alerts #13244
+133
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olerichter00
previously approved these changes
Dec 7, 2023
src/Apps/Artwork/ArtworkApp.tsx
Outdated
| @@ -358,6 +378,13 @@ export const ArtworkAppFragmentContainer = createFragmentContainer( | |||
| attributionClass { | |||
| internalID | |||
| } | |||
| artistSeriesConnection(first: 20) { | |||
There was a problem hiding this comment.
I wonder whether it is important and if we should limit the artist series criteria to an overseeable limit to avoid showing up to 20 criteria in the "Create Alert" flow.
There was a problem hiding this comment.
Good eye, I didn't pick that number carefully, I just remembered that the max # of series per artwork was 12(!)
The actual distribution looks like this:
The vast majority 94.5% of works in artist series belong to no more than 2 series.
And if we allow up to 5 series, that covers 99.98%. So I think 5 is a good limit here, with the understanding that a tiny handful of works might not reveal all of their series as initial criteria.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type of this PR is: Feat
This PR solves ONYX-563
Description
Adds the artwork's artist series to the initial inferred criteria for an alert created for an artwork page.