Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(alerts): add artist series to initial criteria for artwork-based alerts #13244

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+133 −14
Draft

feat(alerts): add artist series to initial criteria for artwork-based alerts #13244

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66e9477
feat(alerts): add artist series to initial criteria
anandaroop Dec 7, 2023
d04389d
feat: limit number of series suggestions to 5
anandaroop Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 28 additions & 1 deletion src/Apps/Artwork/ArtworkApp.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ import { ArtworkAuctionCreateAlertHeaderFragmentContainer } from "Apps/Artwork/C
import { compact } from "lodash"
import { AlertProvider } from "Components/Alert/AlertProvider"
import { FullBleedBanner } from "Components/FullBleedBanner"
import { extractNodes } from "Utils/extractNodes"
import { useFeatureFlag } from "System/useFeatureFlag"

export interface Props {
artwork: ArtworkApp_artwork$data
Expand Down Expand Up @@ -300,7 +302,14 @@ export const ArtworkApp: React.FC<Props> = props => {

const WrappedArtworkApp: React.FC<Props> = props => {
const {
artwork: { artists, attributionClass, internalID, mediumType, sale },
artwork: {
artists,
artistSeriesConnection,
attributionClass,
internalID,
mediumType,
sale,
},
} = props

const {
Expand All @@ -314,6 +323,10 @@ const WrappedArtworkApp: React.FC<Props> = props => {
const referrer = state && state.previousHref
const { isComplete } = useRouteComplete()

const isArtistSeriesFilterEnabled = useFeatureFlag(
"onyx_enable-artist-series-filter"
)

const websocketEnabled = !!sale?.extendedBiddingIntervalMinutes

const initialAlertCriteria = {
Expand All @@ -322,6 +335,13 @@ const WrappedArtworkApp: React.FC<Props> = props => {
additionalGeneIDs: compact([mediumType?.filterGene?.slug as string]),
}

if (isArtistSeriesFilterEnabled) {
const artistSeriesSlugs = compact(
extractNodes(artistSeriesConnection).map(node => node.slug)
)
initialAlertCriteria["artistSeriesIDs"] = artistSeriesSlugs
}

return (
<Analytics contextPageOwnerId={internalID}>
<WebsocketContextProvider
Expand Down Expand Up @@ -358,6 +378,13 @@ export const ArtworkAppFragmentContainer = createFragmentContainer(
attributionClass {
internalID
}
artistSeriesConnection(first: 20) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder whether it is important and if we should limit the artist series criteria to an overseeable limit to avoid showing up to 20 criteria in the "Create Alert" flow.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good eye, I didn't pick that number carefully, I just remembered that the max # of series per artwork was 12(!)

The actual distribution looks like this:

distr

The vast majority 94.5% of works in artist series belong to no more than 2 series.

And if we allow up to 5 series, that covers 99.98%. So I think 5 is a good limit here, with the understanding that a tiny handful of works might not reveal all of their series as initial criteria.

edges {
node {
slug
}
}
}
slug
internalID
is_acquireable: isAcquireable
Expand Down
6 changes: 6 additions & 0 deletions src/Components/Alert/Hooks/__tests__/AlertProvider.jest.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,11 @@ describe("AlertProvider", () => {
field: "artistIDs",
value: "artist-id",
},
{
displayValue: "Soup Cans",
field: "artistSeriesID",
value: "artist-series-id",
},
],
},
}),
Expand All @@ -106,6 +111,7 @@ describe("AlertProvider", () => {

expect(screen.getByText("Add Filters:")).toBeInTheDocument()
expect(screen.getByText("Andy Warhol")).toBeInTheDocument()
expect(screen.getByText("Soup Cans")).toBeInTheDocument()

// transition to filters step
screen.getByTestId("addFilters").click()
Expand Down
66 changes: 56 additions & 10 deletions src/__generated__/ArtworkApp_artwork.graphql.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading