Improve progress behavior

amr-abdelfattah · May 3, 2020 · 30ffcd5 · 30ffcd5
1 parent 12b0064
commit 30ffcd5
Show file tree

Hide file tree

Showing 9 changed files with 18 additions and 14 deletions.
diff --git a/Example/FileDownloadingCenter.xcodeproj/project.pbxproj b/Example/FileDownloadingCenter.xcodeproj/project.pbxproj
@@ -538,7 +538,7 @@
 				INFOPLIST_FILE = FileDownloadingCenter/Info.plist;
 				IPHONEOS_DEPLOYMENT_TARGET = 10.0;
 				LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
-				MARKETING_VERSION = 1.1.1;
+				MARKETING_VERSION = 1.1.3;
 				MODULE_NAME = ExampleApp;
 				PRODUCT_BUNDLE_IDENTIFIER = "com.amr-abdelfattah.FileDownloadingCenter-Example";
 				PRODUCT_NAME = "$(TARGET_NAME)";
@@ -556,7 +556,7 @@
 				INFOPLIST_FILE = FileDownloadingCenter/Info.plist;
 				IPHONEOS_DEPLOYMENT_TARGET = 10.0;
 				LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
-				MARKETING_VERSION = 1.1.1;
+				MARKETING_VERSION = 1.1.3;
 				MODULE_NAME = ExampleApp;
 				PRODUCT_BUNDLE_IDENTIFIER = "com.amr-abdelfattah.FileDownloadingCenter-Example";
 				PRODUCT_NAME = "$(TARGET_NAME)";

diff --git a/Example/FileDownloadingCenter/TrackTableViewCell.swift b/Example/FileDownloadingCenter/TrackTableViewCell.swift
@@ -45,7 +45,9 @@ class TrackTableViewCell: UITableViewCell {
 
     private func setIsDownloading(_ isDownloading: Bool) {
 
-        self.detailTextLabel?.text = isDownloading ? "Downloading ..." : ""
+      DispatchQueue.main.async {
+       self.detailTextLabel?.text = isDownloading ? "Downloading ..." : ""
+      }
 
     }
 

diff --git a/Example/Podfile.lock b/Example/Podfile.lock
@@ -1,5 +1,5 @@
 PODS:
-  - FileDownloadingCenter (1.1.0)
+  - FileDownloadingCenter (1.1.3)
   - ReachabilitySwift (5.0.0)
 
 DEPENDENCIES:
@@ -15,7 +15,7 @@ EXTERNAL SOURCES:
     :path: "../"
 
 SPEC CHECKSUMS:
-  FileDownloadingCenter: adfa6ef6b24b97db22c6cdd8906b70536e5ba815
+  FileDownloadingCenter: c18664d86f0ce60e8739c8a0d8e178bd19f3b219
   ReachabilitySwift: 985039c6f7b23a1da463388634119492ff86c825
 
 PODFILE CHECKSUM: c957ad9504adcf9fa2f52fe3ea1e538970a89dd3

diff --git a/Example/Pods/Local Podspecs/FileDownloadingCenter.podspec.json b/Example/Pods/Local Podspecs/FileDownloadingCenter.podspec.json
diff --git a/Example/Pods/Manifest.lock b/Example/Pods/Manifest.lock
diff --git a/Example/Pods/Target Support Files/FileDownloadingCenter/FileDownloadingCenter-Info.plist b/Example/Pods/Target Support Files/FileDownloadingCenter/FileDownloadingCenter-Info.plist
diff --git a/FileDownloadingCenter.podspec b/FileDownloadingCenter.podspec
@@ -8,7 +8,7 @@
 
 Pod::Spec.new do |s|
   s.name             = 'FileDownloadingCenter'
-  s.version          = '1.1.1'
+  s.version          = '1.1.3'
   s.summary          = 'File Downloading Center is an iOS downloading library for files.'
   s.description      = 'File Downloading Center is used for facilitating the files downloading and all its stuff from storing, restoring, displaying, ...'
   s.author       = { 'Amr Elsayed' => 'amrelsayed.mohamed@gmail.com' }

diff --git a/FileDownloadingCenter/Classes/DownloadCenter/Extensions/SafeDictionary.swift b/FileDownloadingCenter/Classes/DownloadCenter/Extensions/SafeDictionary.swift
@@ -73,7 +73,8 @@ class SafeDictionary<K: Hashable, V> {
         set {
 
             print("DOWNLOAD ALL SET BEFORE \(key)")
-            self.concurrentQueue.async(flags: .barrier) {
+//            self.concurrentQueue.async(flags: .barrier) {
+          self.concurrentQueue.sync {
 
                 print("DOWNLOAD ALL SET DONE \(key)")
                 self.dictionary[key] = newValue

diff --git a/FileDownloadingCenter/Classes/ModelDownloaderManager/ModelDownloaderManager.swift b/FileDownloadingCenter/Classes/ModelDownloaderManager/ModelDownloaderManager.swift
@@ -162,8 +162,8 @@ public extension ModelDownloaderManager {
 
         DispatchQueue.global(qos: .background).async {
 
-            let downloader = notification.object as! FileDownloader
-            
+          if let downloader = notification.object as? FileDownloader {
+
             for downloaderListener in self.downloaderListeners {
 
                     if self.isEnabledListener(downloaderListener, forIdentifier: downloader.identifier) {
@@ -178,6 +178,7 @@ public extension ModelDownloaderManager {
 
             }
 
+          }
             print("LISTENER: didUpdateProgress 2")
 
         }