Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated docs: Corrected link for common data model formats #45

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Updated docs: Corrected link for common data model formats #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/intro.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ And here is the **generated** Plant UML diagram for the model:

🔎 Runtime introspection of the model using a powerful set of APIs

🎛 Convert the model to [14+ common data model formats](./category/code-generation)
🎛 Convert the model to [14+ common data model formats](https://concerto.accordproject.org/docs/category/code-generation)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work for local or PR builds. Does it work if you replace the leading . with /docs?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, i agree it won't work for local or PR builds. Here are two cases:

  1. One link takes to /docs/intro/
  2. Other link takes to /docs
    So if we do . with /docs, then would work for second case but fail for the first case as then it would become /docs/docs

Is it possible to have same path for both when you go from learn tutorial or from Quick tutorial?

I would say lets fix for now, so there is no broken link.. In parallel, can see how to fix this at application level by correcting paths.


🕸 Publish your reusable models to any website, including the Accord Project [model repository](https://models.accordproject.org)

Expand Down