Updated docs: Corrected link for common data model formats #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saurav Gupta <Saurav.Gupta@docusign.com>
✅ Deploy Preview for concerto-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mttrbrts
requested changes
May 5, 2024
| @@ -49,7 +49,7 @@ And here is the **generated** Plant UML diagram for the model: | |||
|
|
|||
| 🔎 Runtime introspection of the model using a powerful set of APIs | |||
|
|
|||
| 🎛 Convert the model to [14+ common data model formats](./category/code-generation) | |||
| 🎛 Convert the model to [14+ common data model formats](https://concerto.accordproject.org/docs/category/code-generation) | |||
There was a problem hiding this comment.
This won't work for local or PR builds. Does it work if you replace the leading . with /docs?
There was a problem hiding this comment.
Yes, i agree it won't work for local or PR builds. Here are two cases:
- One link takes to /docs/intro/
- Other link takes to /docs
So if we do . with /docs, then would work for second case but fail for the first case as then it would become /docs/docs
Is it possible to have same path for both when you go from learn tutorial or from Quick tutorial?
I would say lets fix for now, so there is no broken link.. In parallel, can see how to fix this at application level by correcting paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Changes
Flags
Screenshots or Video
Related Issues
Author Checklist
--signoffoption of git commit.masterfromfork:branchname