Added the SBOL Visual Ontology v2.3 #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 29, 2020
jakebeal
reviewed
Nov 29, 2020
|  | ||
|  | ||
|  | ||
|  |
There was a problem hiding this comment.
Should these really be taken as specifications? They are particular examples of compositions, which could be used canonically, but they are only a few of the many potential compositions.
|
I thought they were specifications. They used to be specifications. Was there an SEP for this? Can we please take them as specifications for now? The alternative SBGN glyph is also provided. |
|
They've never been specifications in the ordinary sense, which I think is where the confusion came in. Let's go with it for now, though, and we can revisit in the future. I've set up an issue (#136) to track this question. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes the fixes for issue #96, #88 and #106.