Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feedbackRedirect #353

Merged
merged 1 commit into from
Nov 19, 2024
Merged

feedbackRedirect #353

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions vercel.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@
"destination": "https://opencollective.com/boston-ts-club",
"permanent": true,
"source": "/donate"
},
{
"destination": "https://docs.google.com/forms/d/e/1FAIpQLSevxqyXjEE2AQ8C7xxkmoiiasr5ONIvPyAl8ad-MseNZ2ZBxA/viewform",
"permanent": false,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine, I debated as well and leaned the other direction, but I'm happy either way.

In that case, care to make /donate non-permanent as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you see the donate link changing? I just see the feedback link changing more often than not

Copy link
Collaborator

@astorije astorije Nov 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, I don't see either changing but I'm not known for my accurate predictions lol.

I'm happy either way tbh. @JoshuaKGoldberg does the /donate = permanent / /feedback = non-permanent seem good to you? Any additional feedback / preference?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just go with this so it's available tonight. Nothing we can't fix later.

"source": "/feedback"
}
]
}
Loading