-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feedbackRedirect #353
feedbackRedirect #353
Conversation
@xav-ie is attempting to deploy a commit to the SquiggleTools Team on Vercel. A member of the Team first needs to authorize it. |
9e1f566
to
ea2bd60
Compare
}, | ||
{ | ||
"destination": "https://docs.google.com/forms/d/e/1FAIpQLSevxqyXjEE2AQ8C7xxkmoiiasr5ONIvPyAl8ad-MseNZ2ZBxA/viewform", | ||
"permanent": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine, I debated as well and leaned the other direction, but I'm happy either way.
In that case, care to make /donate
non-permanent as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you see the donate link changing? I just see the feedback link changing more often than not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heh, I don't see either changing but I'm not known for my accurate predictions lol.
I'm happy either way tbh. @JoshuaKGoldberg does the /donate
= permanent / /feedback
= non-permanent seem good to you? Any additional feedback / preference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just go with this so it's available tonight. Nothing we can't fix later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!!
d848546
into
SquiggleTools:astorije/redirects
PR Checklist
status: accepting prs
Overview
This makes it so we can change where the form is hosted easily. I make it not permanent. The reason for
permanent: false
is that it changes the status code to 307 from 308. 308 status code gets SEO ranking and probably (not documented) some caching. Since the URL is subject to change, we do not want to SEO rank the google form.https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/307
https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/308
🐢