Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feedbackRedirect #353

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

xav-ie
Copy link
Contributor

@xav-ie xav-ie commented Nov 19, 2024

  • feat(feedback): add redirect

PR Checklist

Overview

This makes it so we can change where the form is hosted easily. I make it not permanent. The reason for permanent: false is that it changes the status code to 307 from 308. 308 status code gets SEO ranking and probably (not documented) some caching. Since the URL is subject to change, we do not want to SEO rank the google form.

https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/307
https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/308
🐢

Copy link

vercel bot commented Nov 19, 2024

@xav-ie is attempting to deploy a commit to the SquiggleTools Team on Vercel.

A member of the Team first needs to authorize it.

@xav-ie xav-ie changed the base branch from main to astorije/redirects November 19, 2024 16:11
@xav-ie xav-ie marked this pull request as ready for review November 19, 2024 16:15
vercel.json Outdated Show resolved Hide resolved
},
{
"destination": "https://docs.google.com/forms/d/e/1FAIpQLSevxqyXjEE2AQ8C7xxkmoiiasr5ONIvPyAl8ad-MseNZ2ZBxA/viewform",
"permanent": false,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine, I debated as well and leaned the other direction, but I'm happy either way.

In that case, care to make /donate non-permanent as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you see the donate link changing? I just see the feedback link changing more often than not

Copy link
Collaborator

@astorije astorije Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, I don't see either changing but I'm not known for my accurate predictions lol.

I'm happy either way tbh. @JoshuaKGoldberg does the /donate = permanent / /feedback = non-permanent seem good to you? Any additional feedback / preference?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just go with this so it's available tonight. Nothing we can't fix later.

Copy link
Collaborator

@astorije astorije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@astorije astorije merged commit d848546 into SquiggleTools:astorije/redirects Nov 19, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants