Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor todos and removed outdated todos #3593

Closed
wants to merge 3 commits into from
Closed

refactor todos and removed outdated todos #3593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
12e2f66
refactor todos and removed outdated todos
VincentUllal Dec 15, 2023
1aaf2d0
refactor without eval()
VincentUllal Dec 18, 2023
71822c1
revert refactor changes
VincentUllal Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/SplitView.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,4 +466,4 @@
}
}
}
</style>
</style>
2 changes: 1 addition & 1 deletion core/src/TopNavDropDown.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,4 +170,4 @@
vertical-align: top;
}
}
</style>
</style>
2 changes: 1 addition & 1 deletion core/src/navigation/LeftNav.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1422,4 +1422,4 @@
outline-color: var(--sapContent_FocusColor);
outline-style: var(--sapContent_FocusStyle);
}
</style>
</style>
2 changes: 1 addition & 1 deletion core/src/navigation/LogoTitle.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,4 +396,4 @@
display: none;
}
}
</style>
</style>
5 changes: 0 additions & 5 deletions core/src/navigation/MobileTopNavDropDown.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,11 +103,6 @@
</div>

<style type="text/scss">
/* TODO remove after update to fundamental 0.9 */
.fd-product-switch__item.selected .fd-product-switch__title:before,
.fd-product-switch__item.selected .fd-product-switch__title:after {
content: none !important;
}

@media (max-width: 1023px) {
.fd-product-switch__body--mobile {
Expand Down
2 changes: 1 addition & 1 deletion core/src/navigation/TabNav.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,4 +614,4 @@
:global(.lui-tabs .fd-tabs__item.fd-tabs__item.hide_element) {
display: none;
}
</style>
</style>
19 changes: 0 additions & 19 deletions scripts/tools/release-cli/release-cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,19 +119,6 @@ function addToChangelog(versionText, changelog, lastline) {
logHeadline('Appended changelog');
}

// function replaceInAllFiles(search, replace) {
// try {
// // TODO: Getting errors while it is working fine from command line. Seems node cannot handle pipes while evaluating commands.
// require('child_process').execSync(
// `cd ${__dirname} && ./replaceInAllFiles.sh "${search}" "${replace}"`,
// { stdio: [0, 1, 2] }
// );
// logHeadline('\nReplaced version in files.');
// } catch (error) {
// logError('Replace error:', error);
// }
// }

/**
* PROMPT
*/
Expand Down Expand Up @@ -233,12 +220,6 @@ function addToChangelog(versionText, changelog, lastline) {
}
} // end if changelog

/**
* REPLACE VERSION IN FILES
*/
// TODO: disabled due to runtime errors and added as console log
// replaceInAllFiles('NEXTRELEASE', `${input.version}`);

/**
* UPDATE PACKAGE-LOCKS
* Skip when running in ci for nightly.
Expand Down