Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor todos and removed outdated todos #3593

Closed
wants to merge 3 commits into from
Closed

refactor todos and removed outdated todos #3593

wants to merge 3 commits into from
+5 −29

Conversation

VincentUllal
Copy link
Member

@VincentUllal VincentUllal commented Dec 15, 2023 •
edited by ndricimrr
Loading

Description

Draft PR

Related issue(s)

Fixes #3578

ndricimrr
ndricimrr reviewed Dec 18, 2023
View reviewed changes
Copy link
Contributor

@ndricimrr ndricimrr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one comment. Rest looks okay. Will check again. Maybe remove the eval solution and look for another TODO instead if it can't be done without eval.

Seems like we have some merge conflicts that need to be resolved below too.

core/src/App.svelte Outdated Show resolved Hide resolved
@ndricimrr ndricimrr added internal Stuff like NFRs, CI pipeline refactoring Something needs to be refactored in a separate task labels Dec 18, 2023
@VincentUllal VincentUllal deleted the 3532-resolve-Todos branch December 20, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndricimrr ndricimrr ndricimrr left review comments

@alexandra-simeonova alexandra-simeonova Awaiting requested review from alexandra-simeonova

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@JohannesDoberer JohannesDoberer Awaiting requested review from JohannesDoberer JohannesDoberer is a code owner

@camelCaseChris camelCaseChris Awaiting requested review from camelCaseChris

Assignees
No one assigned
Labels
internal Stuff like NFRs, CI pipeline refactoring Something needs to be refactored in a separate task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resolve TODOs in repo: Remove some outdated TODOs and refactoring
2 participants
@VincentUllal @ndricimrr