-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Yeast Project #4
base: main
Are you sure you want to change the base?
Conversation
Updated README to indicate run order for the files, created raw & processed data folders, added my SPRAS config file and created yaml file for my conda environment with required packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request follows up on #1. Let's continue to modify these files in this pull request instead of creating a new one with updates.
I can clarify any of these comments that are confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Including the complete set of packages and specific versions is good for documentation. That type of environment file is usually hard to re-install on a new machine with a different operating system. We could work on a minimal environment file that is more portable.
There is a lot of discussion of that here: https://stackoverflow.com/questions/39280638/how-to-share-conda-environments-across-platforms
The accepted answer is to create an environment file by hand that lists the important packages you use and their versions. There is also conda env export --from-history
that exports only packages you installed, which may or may not be helpful depending on how you set up the environment.
Co-authored-by: Anthony Gitter <agitter@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like most of the initial review comments have been addressed. A few remaining things I noticed are:
- the version of
matplotlib_venn
so we can add it to the environment file - a Raw_data section in the readme with links to the original file sources
- include the dummy file in Raw_data
There could be other small things I missed.
Updated Readme file with file run order, more details and environment setup. Create raw & processed data folders. Added my SPRAS config file and saved conda environment and required packages as a yaml file.