Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Yeast Project #4

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

D3xtersLab
Copy link

Updated Readme file with file run order, more details and environment setup. Create raw & processed data folders. Added my SPRAS config file and saved conda environment and required packages as a yaml file.

D3xtersLab and others added 3 commits July 26, 2024 13:00
Updated README to indicate run order for the files, created raw & processed data folders, added my SPRAS config file and created yaml file for my conda environment with required packages
Copy link
Collaborator

@agitter agitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request follows up on #1. Let's continue to modify these files in this pull request instead of creating a new one with updates.

I can clarify any of these comments that are confusing.

Yeast_Project/Scripts/requirements.txt Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Including the complete set of packages and specific versions is good for documentation. That type of environment file is usually hard to re-install on a new machine with a different operating system. We could work on a minimal environment file that is more portable.

There is a lot of discussion of that here: https://stackoverflow.com/questions/39280638/how-to-share-conda-environments-across-platforms

The accepted answer is to create an environment file by hand that lists the important packages you use and their versions. There is also conda env export --from-history that exports only packages you installed, which may or may not be helpful depending on how you set up the environment.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Yeast_Project/Scripts/2_Node_Summary_Histo.ipynb Outdated Show resolved Hide resolved
Yeast_Project/Scripts/3_Oi1_Output_eval.ipynb Outdated Show resolved Hide resolved
Yeast_Project/Scripts/3_Oi1_Output_eval.ipynb Outdated Show resolved Hide resolved
Yeast_Project/Scripts/3_Oi1_Output_eval.ipynb Outdated Show resolved Hide resolved
Yeast_Project/Scripts/Required_files/pathway.txt Outdated Show resolved Hide resolved
Copy link
Collaborator

@agitter agitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like most of the initial review comments have been addressed. A few remaining things I noticed are:

  • the version of matplotlib_venn so we can add it to the environment file
  • a Raw_data section in the readme with links to the original file sources
  • include the dummy file in Raw_data

There could be other small things I missed.

Added Raw_Data files & links to README, Updated environment file with just the packages required, tested the environment recreation, added more to README file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants