Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(APIv2): self-joining in aggregation with a reduced (pundit) scope #2322

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

skateman
Copy link
Member

@skateman skateman commented Nov 26, 2024

I am introducing the aggregate method on pundit scopes that allows us additional scoping of resources for aggregations. This is not for user access limitation, but for performance optimizations in SQL. User access scoping is always handled on the highest level and in FILTER calls inside aggregation. Hopefully we will only need this for the inventory, that is scoped with org_id, but this could be useful for rule results or test results if there are performance issues.

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@skateman skateman requested a review from a team as a code owner November 26, 2024 15:07
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.79%. Comparing base (10ba39b) to head (f6fc32b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2322   +/-   ##
=======================================
  Coverage   98.78%   98.79%           
=======================================
  Files         237      237           
  Lines        5203     5210    +7     
=======================================
+ Hits         5140     5147    +7     
  Misses         63       63           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skateman skateman enabled auto-merge (rebase) November 27, 2024 06:53
@skateman skateman merged commit 0c0012e into RedHatInsights:master Nov 27, 2024
12 checks passed
@skateman skateman deleted the pundit-scope-aggregate branch November 27, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants