perf(APIv2): self-joining in aggregation with a reduced (pundit) scope #2322
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am introducing the
aggregate
method on pundit scopes that allows us additional scoping of resources for aggregations. This is not for user access limitation, but for performance optimizations in SQL. User access scoping is always handled on the highest level and in FILTER calls inside aggregation. Hopefully we will only need this for the inventory, that is scoped with org_id, but this could be useful for rule results or test results if there are performance issues.Secure Coding Practices Checklist GitHub Link
Secure Coding Checklist