perf(APIv2): self-joining in aggregation with a reduced (pundit) scope

RedHatInsights · Nov 26, 2024 · 2329e6f · 2329e6f
1 parent 10ba39b
commit 2329e6f
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/app/controllers/concerns/v2/resolver.rb b/app/controllers/concerns/v2/resolver.rb
@@ -58,12 +58,14 @@ def join_aggregated(relation)
     # INNER JOIN (
     #   SELECT "resource"."id", AGG("association"."XY"), AGG("association"."XZ")
     #   FROM "resource" LEFT OUTER JOIN "association" ...
+    #   GROUP BY "resource"."id" WHERE pundit_scope()
     # ) "aggregate_association" ON "aggregate_association"."id" = "resource"."id";
     # ```
     #
     def subquery_fragment(association, aliases)
       sq = resource.left_outer_joins(association)
                    .group(resource.primary_key)
+                   .merge_with_alias(pundit_scope(resource))
                    .select(resource.primary_key, *aliases)
       resource.arel_self_join(sq.arel.as(association.to_s))
     end