Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move mod content related logic to dedicated package #829

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

Alystrasz
Copy link
Contributor

Currently, mod manager and mod code are located in the same modmanager.cpp package.
To ease development iterations over the mod system, I propose to separate mod manager from mod, and export the latter to a dedicated package.

@github-actions github-actions bot added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Nov 25, 2024
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just moves all the Mod class and any related logic to its own file. Manually verified that there were no additional code changes done during the move.

Don't think this needs any testing.

@GeckoEidechse GeckoEidechse added READY TO MERGE This mergeable right now and removed needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Nov 25, 2024
@GeckoEidechse GeckoEidechse changed the title refactor: Export mod content to dedicated package refactor: Move mod content related logic to dedicated package Nov 27, 2024
@GeckoEidechse GeckoEidechse merged commit 21843ee into R2Northstar:main Nov 27, 2024
4 checks passed
@Alystrasz Alystrasz deleted the refactor/mod-package branch November 28, 2024 18:10
@Alystrasz Alystrasz removed the READY TO MERGE This mergeable right now label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants