-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Mod information extraction #830
base: main
Are you sure you want to change the base?
refactor: Mod information extraction #830
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we don't return anything from the helper function and instead directly store it in the method field?
As opposed to calling the helper function, returning the collected information and then storing it in the field?
(Not saying it needs to be changed, just curious ^^)
I simply exported some code into this new function, that initializes the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Open questions have been addressed. Just moves code around as verified when checking locally.
Apart from the return value aspect which I'd be happy for someone else to also comment on this should be good from the code review side of things ^^
Tbh, not even sure if this needs testing or not. Could just test in prod. |
In the same fashion than #829, extracts some
ModManager
code into a dedicated method (and adds some documentation as a bonus).