-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency Constant Version Tables #685
base: main
Are you sure you want to change the base?
Conversation
Oooh, I like this a lot :D I assume the commented out code is still planned to be cleaned up? ^^ |
Co-authored-by: GeckoEidechse <40122905+GeckoEidechse@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
your semver parser crashed :|
patch is empty and minor has a .
no stack trace in logs
mods that made it crash : live holo & holo mimic
it crashed at CreateSlot("patch", stoi(patch));
btw
I guess this needs a preliminary check if mod version is even properly formatted and fail out if not? |
@uniboi bump |
Converting to draft until merge conflicts are addressed. cc @uniboi |
0
major
,minor
andpatch
keys for the versions of the mod1.x.x
would only expose themajor
key