Turn dependency constant into table #745
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to store information about the dependency, such as the version string an an attempt at parsing the version as semver. Co-authored-by: uniboi <64006268+uniboi@users.noreply.github.com>
Jan200101
added
needs testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #685
credits to @uniboi for the original implementation
turns dependency constant from a plain boolean value to an optional table with the following attributes:
versioncontains the raw version string of the dependencymajor,minor,patchcontains an attempt at parsing the above version string naively as semver.-1reworked from scratch to add fewer functions and fix some bugs all around.