Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Restrict read access by default to powershell core logs #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] Restrict read access by default to powershell core logs #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/PowerShell.Core.Instrumentation/PowerShell.Core.Instrumentation.man
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2190,6 +2190,12 @@
event provider
1. Operational - for high level diagnositc messages
2. Analytic - for high volume high performance trace messages

read access to restricted to:
local system (A;;0xf0007;;;SY)
built-in admins (A;;0x7;;;BA)
server operators (A;;0x7;;;SO)
event log readers (A;;0x1;;;S-1-5-32-573)
-->
<channel
chid="C_OPERATIONAL"
Expand All @@ -2199,6 +2205,7 @@
name="PowerShellCore/Operational"
symbol="C_OPERATIONAL"
type="Operational"
access="O:BAG:SYD:(A;;0xf0007;;;SY)(A;;0x7;;;BA)(A;;0x7;;;SO)(A;;0x1;;;S-1-5-32-573)"
>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The inbox has these additional permissions:

InputObject                                                                       SideIndicator
-----------                                                                       -------------
NT AUTHORITY\BATCH: AccessAllowed (ListDirectory, WriteData)                      <=
NT AUTHORITY\INTERACTIVE: AccessAllowed (ListDirectory, WriteData)                <=
NT AUTHORITY\SERVICE: AccessAllowed (ListDirectory, WriteData)                    <=
NT AUTHORITY\WRITE RESTRICTED: AccessAllowed (ListDirectory, WriteData)           <=
APPLICATION PACKAGE AUTHORITY\ALL APPLICATION PACKAGES: AccessAllowed (WriteData) <=
: AccessAllowed (WriteData)                                                       <=

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

batch, interactive and service shouldn't be allowed. I'm not sure about the other two.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading https://techcommunity.microsoft.com/t5/Ask-The-Performance-Team/WS2008-Windows-Service-Hardening/ba-p/372702 Write restricted doesn't give a lot of value here either.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make sure our MSIX can write without APPLICATION PACKAGE AUTHORITY\ALL APPLICATION PACKAGES

<logging>
<!--this log is circular, which means older events
Expand All @@ -2216,6 +2223,7 @@
name="PowerShellCore/Analytic"
symbol="C_ANALYTIC"
type="Analytic"
access="O:BAG:SYD:(A;;0xf0007;;;SY)(A;;0x7;;;BA)(A;;0x7;;;SO)(A;;0x1;;;S-1-5-32-573)"
>
<logging>
<!--this log is not circular, which means user has to
Expand Down Expand Up @@ -2243,6 +2251,7 @@
name="PowerShellCore/Debug"
symbol="C_DEBUG"
type="Debug"
access="O:BAG:SYD:(A;;0xf0007;;;SY)(A;;0x7;;;BA)(A;;0x7;;;SO)(A;;0x1;;;S-1-5-32-573)"
>
<logging>
<!--this log is not circular, which means user has to
Expand Down