Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Restrict read access by default to powershell core logs #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SteveL-MSFT
Copy link
Member

change ACL on Operational, Analytic, and Debug logs to be read only for local system, admins, server operators, and event log readers

…or local system, admins, server operators, and event log readers
@@ -2199,6 +2205,7 @@
name="PowerShellCore/Operational"
symbol="C_OPERATIONAL"
type="Operational"
access="O:BAG:SYD:(A;;0xf0007;;;SY)(A;;0x7;;;BA)(A;;0x7;;;SO)(A;;0x1;;;S-1-5-32-573)"
>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The inbox has these additional permissions:

InputObject                                                                       SideIndicator
-----------                                                                       -------------
NT AUTHORITY\BATCH: AccessAllowed (ListDirectory, WriteData)                      <=
NT AUTHORITY\INTERACTIVE: AccessAllowed (ListDirectory, WriteData)                <=
NT AUTHORITY\SERVICE: AccessAllowed (ListDirectory, WriteData)                    <=
NT AUTHORITY\WRITE RESTRICTED: AccessAllowed (ListDirectory, WriteData)           <=
APPLICATION PACKAGE AUTHORITY\ALL APPLICATION PACKAGES: AccessAllowed (WriteData) <=
: AccessAllowed (WriteData)                                                       <=

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

batch, interactive and service shouldn't be allowed. I'm not sure about the other two.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make sure our MSIX can write without APPLICATION PACKAGE AUTHORITY\ALL APPLICATION PACKAGES

@SteveL-MSFT SteveL-MSFT changed the title Restrict read access by default to powershell core logs DO NOT MERGE: Restrict read access by default to powershell core logs Aug 29, 2019
@SteveL-MSFT
Copy link
Member Author

Let's wait on this one

@adityapatwardhan adityapatwardhan changed the title DO NOT MERGE: Restrict read access by default to powershell core logs [WIP] Restrict read access by default to powershell core logs Sep 4, 2019
@adityapatwardhan
Copy link
Member

@SteveL-MSFT Is this something that will be worked on or should we close the PR?

@adityapatwardhan
Copy link
Member

@SteveL-MSFT - is this PR still needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants