-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modelmatcher changes #72
base: development
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -205,4 +205,4 @@ | |
</plugins> | ||
</build> | ||
|
||
</project> | ||
</project> |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -50,11 +50,12 @@ public void updateOrganInfos() { | |
OrganInfo organInfo = organInfoRepository.findByUberonId( term.getId() ); | ||
if ( organInfo == null ) { | ||
organInfo = new OrganInfo(); | ||
organInfo.setName( term.getName() ); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We need to add the description here as well. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's a bit silly if we do that because we can only add missing organ systems, never update anything. |
||
organInfo.setUberonId( term.getId() ); | ||
// only show organs that have been explicitly activated | ||
organInfo.setActive( false ); | ||
} | ||
organInfo.setName( term.getName() ); | ||
|
||
organInfo.setDescription( term.getDefinition() ); | ||
organInfoRepository.save( organInfo ); | ||
} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,6 @@ | ||
a{ | ||
color: teal; | ||
} | ||
html { | ||
position: relative; | ||
min-height: 100%; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,9 @@ | ||
a{ | ||
color:teal | ||
} | ||
.btn{ | ||
background-color:teal | ||
} | ||
html, body { | ||
margin: 0; | ||
height: 100%; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,22 +14,22 @@ | |
class="text-center" | ||
scope="col" | ||
data-toggle="tooltip" | ||
th:title="${viewOnly} == null ? 'Primary genes constitute your TIER1 genes whereas non-primary genes will be part of your TIER2 genes.' : 'Tier determines the degree of involvment of a researcher with a gene.'"> | ||
th:title="${viewOnly} == null ? 'Primary genes are genes that your lab is actively working on, or genes where you have assays and reagents ready for immediately study.' : 'Tier determines the degree of involvment of a researcher with a gene.'"> | ||
<span th:text="${viewOnly == null} ? 'Primary' : 'Tier'"></span> | ||
<i class="tip oi oi-question-mark"></i> | ||
</th> | ||
<th th:if="${viewOnly == null} and ${@applicationSettings.privacy.isCustomizableGeneLevel()}" | ||
class="text-center" | ||
scope="col" | ||
data-toggle="tooltip" | ||
title="Privacy level determines who can see this gene in a search result."> | ||
title="Public genes can be searched by all users. Restricted genes require a match request to be submitted."> | ||
Privacy Level | ||
<i class="tip oi oi-question-mark"></i> | ||
</th> | ||
</tr> | ||
</thead> | ||
<tbody> | ||
<tr th:each="gene : ${genes}"> | ||
<tr th:if="${gene.effectivePrivacyLevel != T(ubc.pavlab.rdp.model.enums.PrivacyLevelType).PRIVATE or viewOnly == null}" th:each="gene : ${genes}"> | ||
<td class="align-middle"> | ||
<i th:if="${viewOnly == null}" class="delete-row align-middle"></i> | ||
<a th:href="@{https://www.ncbi.nlm.nih.gov/gene/{geneId}(geneId=${gene.geneId})}" | ||
|
@@ -49,7 +49,7 @@ | |
th:checked="${gene.tier == T(ubc.pavlab.rdp.model.enums.TierType).TIER1}"/> | ||
</td> | ||
<td th:if="${viewOnly != null}" | ||
th:text="${gene.tier}" | ||
th:text="${gene.tier==T(ubc.pavlab.rdp.model.enums.TierType).TIER1}?'Primary':'Secondary'" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Here we should use the labels from the TierType, and possible use i18n to allow instance to change the wording. |
||
class="text-center"></td> | ||
</th:block> | ||
<td th:if="${viewOnly == null} and ${@applicationSettings.privacy.isCustomizableGeneLevel()}" | ||
|
@@ -63,12 +63,15 @@ | |
</select> | ||
</td> | ||
</tr> | ||
|
||
</tbody> | ||
<!-- | ||
<tfoot th:if="${viewOnly != null}"> | ||
<tr> | ||
<td colspan="3"></td> | ||
</tr> | ||
</tfoot> | ||
--> | ||
</table> | ||
</body> | ||
</html> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to handle the error if a registry is missing a taxon.