modelmatcher changes #72
Conversation
There was a problem hiding this comment.
@lucianli123 Have you found gene information for fission yeast?
| } | ||
| else{ | ||
| data=new HashSet<>(); | ||
| } |
There was a problem hiding this comment.
We need to handle the error if a registry is missing a taxon.
| @@ -50,11 +50,12 @@ public void updateOrganInfos() { | |||
| OrganInfo organInfo = organInfoRepository.findByUberonId( term.getId() ); | |||
| if ( organInfo == null ) { | |||
| organInfo = new OrganInfo(); | |||
| organInfo.setName( term.getName() ); | |||
There was a problem hiding this comment.
We need to add the description here as well.
There was a problem hiding this comment.
It's a bit silly if we do that because we can only add missing organ systems, never update anything.
| @@ -49,7 +49,7 @@ | |||
| th:checked="${gene.tier == T(ubc.pavlab.rdp.model.enums.TierType).TIER1}"/> | |||
| </td> | |||
| <td th:if="${viewOnly != null}" | |||
| th:text="${gene.tier}" | |||
| th:text="${gene.tier==T(ubc.pavlab.rdp.model.enums.TierType).TIER1}?'Primary':'Secondary'" | |||
There was a problem hiding this comment.
Here we should use the labels from the TierType, and possible use i18n to allow instance to change the wording.
|
I'll review the changes later. I think most of these have already been addressed in the 1.4 and any issues could be fixed in a patch release. |
|
@lucianli123 You should rebase this change on the master branch, it contains the latest 1.4.1 release. I can help you out if you have merge issues. |
No description provided.