Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep metadata fields when value null #72

Merged
merged 9 commits into from
Jan 19, 2024
Merged

Keep metadata fields when value null #72

merged 9 commits into from
Jan 19, 2024

Conversation

chrwm
Copy link
Member

@chrwm chrwm commented Oct 31, 2022

Closes #71

@chrwm
Set omit_none=False #71
93d07cd 
With changing to False, metadata json keys and values will remain in the metadata as `null` after processing with omi.
@chrwm chrwm requested a review from jh-RLI October 31, 2022 11:16
@chrwm chrwm self-assigned this Oct 31, 2022
@jh-RLI
Copy link
Contributor

jh-RLI commented Nov 10, 2022 •
edited
Loading

The tests fail because they are implemented to assume that the fields are discarded if they are none / null.
So we have to change the tests / create tests for bot cases (omi_none=true/false).

@jh-RLI jh-RLI mentioned this pull request Jan 19, 2024
Merged
5 tasks
jh-RLI
jh-RLI approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@jh-RLI jh-RLI left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed the code a little to better control the omission of non-values. This helps to keep the old test.

This is now ready for release :)

Note:
I need to do some code cleanup ofc.

@jh-RLI jh-RLI merged commit e13457e into dev Jan 19, 2024
1 check passed
@jh-RLI jh-RLI deleted the feature-71-keep-null-keys-and-values branch January 19, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jh-RLI jh-RLI jh-RLI approved these changes

Assignees

@chrwm chrwm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OMI omits null values from json during processing
2 participants
@chrwm @jh-RLI