Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep null values in oemetadata #1541

Merged
merged 6 commits into from
Jan 25, 2024

Conversation

jh-RLI
Copy link
Contributor

@jh-RLI jh-RLI commented Jan 19, 2024

Summary of the discussion

Only merge if OpenEnergyPlatform/omi#72 is available on pypi

As described in #1273, removing null / none values causes confusion and should therefore not be done by the platform.

This is related to a change in omi that was introduced to give the user control over whether to omit null values. This functionality now retains null values by default.

Type of change (CHANGELOG.md)

Updated

  • The oemetadata on the oep is now stored including null / none values. Users reported that it otherwise is confusing and hinders there metadata workflow. This is related to the update in omi v0.2.0 (PR#1541)

Workflow checklist

Automation

Closes #1273
Closes #1108

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guidelines
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@jh-RLI jh-RLI self-assigned this Jan 19, 2024
@jh-RLI jh-RLI merged commit 079c22b into develop Jan 25, 2024
2 checks passed
@jh-RLI jh-RLI deleted the feature-1273-keep-null-values-in-oemetadata branch January 25, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 participant