Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use DI instead of CoreRegistry #5266

Closed
wants to merge 1 commit into from

test: use DI instead of CoreRegistry

9982431
Select commit
Loading
Failed to load commit list.
Closed

test: use DI instead of CoreRegistry #5266

test: use DI instead of CoreRegistry
9982431
Select commit
Loading
Failed to load commit list.
Terasology Jenkins.io / SpotBugs succeeded Jul 26, 2024 in 0s

1 new issue, 995 total

Total New Outstanding Fixed Trend
995 1 994 0 👎

Reference build: Terasology » engine » develop #78

Details

Severity distribution of new issues

Error Warning High Warning Normal Warning Low
0 0 0 1

Annotations

Check warning on line 330 in engine/src/main/java/org/terasology/engine/world/block/loader/BlockFamilyDefinitionFormat.java

See this annotation in the file changed.

@terasology-jenkins-io terasology-jenkins-io / SpotBugs

SIC_INNER_SHOULD_BE_STATIC

LOW:
Should org.terasology.engine.world.block.loader.BlockFamilyDefinitionFormat$BlockFamilyHandler be a _static_ inner class?
Raw output
<p> This class is an inner class, but does not use its embedded reference to the object which created it.&nbsp; This reference makes the instances of the class larger, and may keep the reference to the creator object alive longer than necessary.&nbsp; If possible, the class should be made static. </p>