Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use DI instead of CoreRegistry #5266

Closed
wants to merge 1 commit into from

test: use DI instead of CoreRegistry

9982431
Select commit
Loading
Failed to load commit list.
Closed

test: use DI instead of CoreRegistry #5266

test: use DI instead of CoreRegistry
9982431
Select commit
Loading
Failed to load commit list.
Terasology Jenkins.io / CheckStyle failed Jul 26, 2024 in 0s

2 new issues

Total New Outstanding Fixed Trend
2 2 0 0 👎

Reference build: Terasology » engine » develop #78

Details

Severity distribution of new issues

Error Warning High Warning Normal Warning Low
0 0 2 0

Annotations

Check warning on line 24 in engine/src/main/java/org/terasology/engine/world/block/loader/BlockFamilyDefinitionFormat.java

See this annotation in the file changed.

@terasology-jenkins-io terasology-jenkins-io / CheckStyle

UnusedImportsCheck

NORMAL:
Unused import - org.terasology.engine.world.generator.internal.WorldGeneratorManager.
Raw output
<p>Since Checkstyle 3.0</p><p> Checks for unused import statements. Checkstyle uses a simple but very reliable algorithm to report on unused import statements. An import statement is considered unused if: </p><ul><li> It is not referenced in the file. The algorithm does not support wild-card imports like <code>import java.io.*;</code>. Most IDE's provide very sophisticated checks for imports that handle wild-card imports. </li><li> It is a duplicate of another import. This is when a class is imported more than once. </li><li> The class imported is from the <code>java.lang</code> package. For example importing <code>java.lang.String</code>. </li><li> The class imported is from the same package. </li><li><b>Optionally:</b> it is referenced in Javadoc comments. This check is on by default, but it is considered bad practice to introduce a compile time dependency for documentation purposes only. As an example, the import <code>java.util.Date</code> would be considered referenced with the Javadoc comment <code>{@link Date}</code>. The alternative to avoid introducing a compile time dependency would be to write the Javadoc comment as <code>{@link java.util.Date}</code>. </li></ul><p> The main limitation of this check is handling the case where an imported type has the same name as a declaration, such as a member variable. </p><p> For example, in the following case the import <code>java.awt.Component</code> will not be flagged as unused: </p><pre><code> import java.awt.Component; class FooBar { private Object Component; // a bad practice in my opinion ... } </code></pre>

Check warning on line 28 in engine/src/main/java/org/terasology/engine/world/block/loader/BlockFamilyDefinitionFormat.java

See this annotation in the file changed.

@terasology-jenkins-io terasology-jenkins-io / CheckStyle

UnusedImportsCheck

NORMAL:
Unused import - org.terasology.engine.registry.CoreRegistry.
Raw output
<p>Since Checkstyle 3.0</p><p> Checks for unused import statements. Checkstyle uses a simple but very reliable algorithm to report on unused import statements. An import statement is considered unused if: </p><ul><li> It is not referenced in the file. The algorithm does not support wild-card imports like <code>import java.io.*;</code>. Most IDE's provide very sophisticated checks for imports that handle wild-card imports. </li><li> It is a duplicate of another import. This is when a class is imported more than once. </li><li> The class imported is from the <code>java.lang</code> package. For example importing <code>java.lang.String</code>. </li><li> The class imported is from the same package. </li><li><b>Optionally:</b> it is referenced in Javadoc comments. This check is on by default, but it is considered bad practice to introduce a compile time dependency for documentation purposes only. As an example, the import <code>java.util.Date</code> would be considered referenced with the Javadoc comment <code>{@link Date}</code>. The alternative to avoid introducing a compile time dependency would be to write the Javadoc comment as <code>{@link java.util.Date}</code>. </li></ul><p> The main limitation of this check is handling the case where an imported type has the same name as a declaration, such as a member variable. </p><p> For example, in the following case the import <code>java.awt.Component</code> will not be flagged as unused: </p><pre><code> import java.awt.Component; class FooBar { private Object Component; // a bad practice in my opinion ... } </code></pre>