fix pmd warnings, codemetrics-2.1.0, gradle-8.4 #5146
Conversation
soloturn
force-pushed
the
develop
branch
2 times, most recently
from
1185e80
to
e02cb3f
Compare
build-logic/build.gradle.kts
Outdated
| // TODO MYSTERY: As of November 7th 2021 virtual-repo-live could no longer be relied on for latest snapshots - Pro feature? | ||
| // We've been using it that way for *years* and nothing likewise changed in the area for years as well. This seems to work .... |
There was a problem hiding this comment.
@Cervator - Do you know if this comment is still relevant with the new artifactory?
There was a problem hiding this comment.
I haven't tested but we should try doing so. With a little luck we can undo the hack. It was a huge upgrade over multiple major versions so it could well have changed the quirky bits a lot.
There was a problem hiding this comment.
if virtual repos do not work it is an artifactory bug. see feature matrix:
https://jfrog.com/help/r/jfrog-hosting-models-documentation/artifactory-comparison-matrix
where i fail to understand your reasoning: why do you want to direct all artifacts through your local repository, instead of listing a standard repo from internet + your own?
There was a problem hiding this comment.
took out the TODO removal, as controversal at the moment.
There was a problem hiding this comment.
So the artifacts specific to this issue actually is snapshot-level builds of our project artifacts - game modules, libraries, etc. They wouldn't be available on the regular internet repos :-)
I think Maven Central is in there somewhere to resolve 3rd party libs. Artifactory may also cache those - cannot quite recall the details.
There was a problem hiding this comment.
you are of course right, the standard repos are before. what distracted me was that the url you list:
https://artifactory.terasology.io/ui/native/virtual-repo-live
takes a while to load and lists internet as well. while i d have expected an url with terasoloty only.
|
Oh, and perhaps important since this talks about PMD: warnings during those scans were adding so much build time in Jenkins that I excluded PMD steps within the Jenkinsfile via f907533 (although huh, the PMD line didn't show up as part of the main commit line) - if this fixes that and restores build times to a decent range I'd be happy to see it hooked back up. |
there is a ticket saying logging got changed to finest which makes it 3 times slower: pmd/pmd#1018 . but for me it does not make a huge difference, local. so i updated the pmd version as well now to 6.55.0, lastest before 7.0.0, just to be sure no known bugs are in. if you want, release MovingBlocks/TeraConfig#22 this and i'll update codemetrics to it. |
soloturn
changed the title
|
this one could be merged now. updated codemetrics, so pmd warnings are gone as MovingBlocks/TeraConfig#22 is used, thanks @jdrueckert ! |
gradle-8.4 fully supports java-21, update link in comment because of new gradle version. codemetrics-2.1.0, has the pmd rules inlined, so warnings are gone now. see MovingBlocks/TeraConfig#19 and MovingBlocks/TeraConfig#22. update pmd to 6.55.0, last release before 7.0.0. update spotbugs gradle plugin to 5.2.0 to makeit work with java-21.
gradle-8.4 released, fully supports java-21. codemetrics-2.1.0 has the pmd rules inlined, so warnings are gone now. see MovingBlocks/TeraConfig#19 . remove a couple of outdated TODOs. adjust a link in a comment to new gradle versions.