Skip to content

Commit

Permalink
fix pmd warnings, codemetrics-2.0.0, gradle-8.4
Browse files Browse the repository at this point in the history
gradle-8.4 released, fully supports java-21. codemetrics-2.0.0
has the pmd rules inlined, so warnings are gone now. see
MovingBlocks/TeraConfig#19 .

remove TODOs for artifactory from 2011. sounds a little old.
  • Loading branch information
soloturn committed Oct 5, 2023
1 parent 983bba1 commit 1185e80
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 6 deletions.
4 changes: 1 addition & 3 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ buildscript {
url = "https://artifactory.terasology.io/artifactory/virtual-repo-live"
}

// TODO MYSTERY: As of November 7th 2011 virtual-repo-live could no longer be relied on for latest snapshots - Pro feature?
// We've been using it that way for *years* and nothing likewise changed in the area for years as well. This seems to work ....
maven {
name = "Terasology snapshot locals"
url = "https://artifactory.terasology.io/artifactory/terasology-snapshot-local"
Expand Down Expand Up @@ -104,7 +102,7 @@ dependencies {


// Config for our code analytics lives in a centralized repo: https://github.com/MovingBlocks/TeraConfig
codeMetrics group: 'org.terasology.config', name: 'codemetrics', version: '1.6.3', ext: 'zip'
codeMetrics group: 'org.terasology.config', name: 'codemetrics', version: '2.0.0', ext: 'zip'

// Natives for JNLua (Kallisti, KComputers)
natives group: 'org.terasology.jnlua', name: 'jnlua_natives', version: '0.1.0-SNAPSHOT', ext: 'zip'
Expand Down
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.3-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.4-all.zip
networkTimeout=10000
validateDistributionUrl=true
zipStoreBase=GRADLE_USER_HOME
Expand Down
2 changes: 0 additions & 2 deletions templates/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ buildscript {
url = "https://artifactory.terasology.io/artifactory/virtual-repo-live"
}

// TODO MYSTERY: As of November 7th 2011 virtual-repo-live could no longer be relied on for latest snapshots - Pro feature?
// We've been using it that way for *years* and nothing likewise changed in the area for years as well. This seems to work ....
maven {
name = "Terasology snapshot locals"
url = "https://artifactory.terasology.io/artifactory/terasology-snapshot-local"
Expand Down

0 comments on commit 1185e80

Please sign in to comment.