Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert summary.simtrial_gs_wlr() to data.table #289

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Convert summary.simtrial_gs_wlr() to data.table #289

merged 1 commit into from
Sep 30, 2024

Conversation

jdblischak
Copy link
Collaborator

Follow-up to #268 and #282

xref: #268 (comment)

Also removed the R CMD check note about ends_with by prefixing with gt::. Alternatively I could use @importFrom gt ends_width to add it to NAMESPACE

@jdblischak jdblischak self-assigned this Sep 27, 2024
LittleBeannie
LittleBeannie approved these changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@LittleBeannie LittleBeannie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jdblischak !

@LittleBeannie LittleBeannie merged commit 5572317 into Merck:main Sep 30, 2024
7 checks passed
@jdblischak jdblischak deleted the dt-summary branch October 1, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LittleBeannie LittleBeannie LittleBeannie approved these changes

Assignees

@jdblischak jdblischak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdblischak @LittleBeannie