Skip to content
This repository has been archived by the owner on May 29, 2024. It is now read-only.

COVID-19 dungeon: Update WIP.md #114

Merged
merged 3 commits into from
Dec 14, 2020
Merged

COVID-19 dungeon: Update WIP.md #114

merged 3 commits into from
Dec 14, 2020

Conversation

Arsenic-ATG
Copy link
Member

@Arsenic-ATG Arsenic-ATG commented Dec 13, 2020 •
edited
Loading

the changes include :-

  1. Reformatting wip.md ✨
  2. Added hyperlink to issue Improvise COVID-19 dungeon  #112 instead of contribution guidelines 🔗
  3. [update] fix typo in WIP.md

@Arsenic-ATG Arsenic-ATG added the documentation Improvements or additions to documentation label Dec 13, 2020
@Arsenic-ATG Arsenic-ATG requested a review from a user December 13, 2020 05:13
ghost
ghost reviewed Dec 13, 2020
View reviewed changes
english/covid-19/WIP.md Outdated Show resolved Hide resolved
ghost
ghost previously approved these changes Dec 13, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Job 👍

@ming-tsai ming-tsai self-requested a review December 13, 2020 20:22
ming-tsai
ming-tsai suggested changes Dec 13, 2020
View reviewed changes
Copy link
Member

@ming-tsai ming-tsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I approved without read the comment

@Arsenic-ATG Arsenic-ATG requested review from ming-tsai and a user December 14, 2020 03:25
ghost
ghost approved these changes Dec 14, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. It's ready for merging

@ghost
Copy link

ghost commented Dec 14, 2020

There is a new issue #115 . If someone creates a PR for that, maybe there will be merge conflicts for this PR. Please note that.

I have replied to the author of the issue to fix it themselves so that they can learn to contribute. Or, will @Arsenic-ATG fix it?

@Arsenic-ATG
Copy link
Member Author

Arsenic-ATG commented Dec 14, 2020 •
edited
Loading

@paulsonjpaul think his/her PR should be merged first, I will take care of the merge conflicts that might occur after it.

@ghost
Copy link

ghost commented Dec 14, 2020

Yes. @ming-tsai should be merging it soon

@ming-tsai
Copy link
Member

Hi @Arsenic-ATG, please solve the merge conflict

@sonarcloud
Copy link

sonarcloud bot commented Dec 14, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Arsenic-ATG
Copy link
Member Author

Hi @Arsenic-ATG, please solve the merge conflict

done 👍

@ming-tsai ming-tsai merged commit f8f9ea2 into MakeContributions:master Dec 14, 2020
@Arsenic-ATG Arsenic-ATG deleted the WIP.md_patch branch December 14, 2020 11:42
This was linked to issues Dec 14, 2020
Link not found #115
Closed
Add more dungeons, rooms or floors - Part 3 #103
Closed
@ming-tsai ming-tsai linked an issue Jan 13, 2021 that may be closed by this pull request
Improvise COVID-19 dungeon #112
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ming-tsai ming-tsai ming-tsai approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improvise COVID-19 dungeon Link not found Add more dungeons, rooms or floors - Part 3
2 participants
@Arsenic-ATG @ming-tsai