Skip to content
This repository has been archived by the owner on May 29, 2024. It is now read-only.

Add more dungeons, rooms or floors - Part 3 #103

Closed
ming-tsai opened this issue Nov 8, 2020 · 10 comments · Fixed by #105, #108, #109, #110 or #113
Closed

Add more dungeons, rooms or floors - Part 3 #103

ming-tsai opened this issue Nov 8, 2020 · 10 comments · Fixed by #105, #108, #109, #110 or #113
Assignees
Labels
beginner Need more contributors enhancement New feature or request good first issue Good for newcomers hacktoberfest-accepted Accepted by hacktoberfest, will marge later help wanted Extra attention is needed

Comments

@ming-tsai
Copy link
Member

It'd be awesome to have a lot of the dungeons, rooms, or floors, so the game could be more fun 😜

🐞 Problem
Currently, we have only a bunch of dungeons, rooms, or floors in the project

🎯 Goal
Have a lot of dungeons, rooms, or floors from the diverse games.

💡 Possible solutions
Add new a new dungeon, rooms, or floors.

How to make it?
Check out Contribution Guidelines

📋 Steps to solve the problem

  1. Comment below about what you've started working on.
  2. Add, commit, push your changes
  3. Submit a pull request and add this in comments - Addresses #
  4. Ask for a review in the comments section of the pull request
  5. Celebrate your contribution to this project 🎉

This issue will close every 10 contributions for adding new room(s) or floor(s)

@ming-tsai ming-tsai added beginner Need more contributors enhancement New feature or request hacktoberfest-accepted Accepted by hacktoberfest, will marge later help wanted Extra attention is needed good first issue Good for newcomers labels Nov 8, 2020
@ghost
Copy link

ghost commented Nov 25, 2020

Hello @ming-tsai . I have forked the pen and is working on creating a new floor and rooms for the existing English dungeon.

@ming-tsai ming-tsai linked a pull request Nov 26, 2020 that will close this issue
@ming-tsai ming-tsai reopened this Nov 26, 2020
@ming-tsai ming-tsai assigned FukurouMakoto and ghost Nov 26, 2020
@ghost
Copy link

ghost commented Nov 27, 2020

Work in Progress: Add a new dungeon "covid-19" under english folder

May take a little long

@FukurouMakoto
Copy link
Contributor

I have an idea for a castle the player might be able to explore. Gives alot of room to work in and room for other people to build off of.

Might also take a while.

@ghost
Copy link

ghost commented Nov 27, 2020

I have an idea for a castle the player might be able to explore. Gives alot of room to work in and room for other people to build off of.

Might also take a while.

You are planning to implement this as a new dungeon or to an existing dungeon?

Nice idea, by the way.

@FukurouMakoto
Copy link
Contributor

I have an idea for a castle the player might be able to explore. Gives alot of room to work in and room for other people to build off of.
Might also take a while.

You are planning to implement this as a new dungeon or to an existing dungeon?

Nice idea, by the way.

Thanks; I'd like for it to be a new dungeon, but I have to find a place it would work in.

@ming-tsai
Copy link
Member Author

@FukurouMakoto, you could Marge the branch using git command

@ghost ghost mentioned this issue Dec 1, 2020
@ghost ghost removed their assignment Dec 1, 2020
@ghost
Copy link

ghost commented Dec 1, 2020

Hi @ming-tsai, please check #110. I can't complete it. I don't know to write a good story, so I have unassigned myself to this issue.
Sorry.

This was linked to pull requests Dec 17, 2020
@ming-tsai ming-tsai assigned Arsenic-ATG, ghost , codely8 and FukurouMakoto and unassigned Arsenic-ATG, FukurouMakoto, ghost and codely8 Dec 17, 2020
@ming-tsai ming-tsai reopened this Dec 22, 2020
@ming-tsai ming-tsai linked a pull request Dec 31, 2020 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.