Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow DebugTypePointer BaseType argument substitution by DebugInfoNone #287

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow DebugTypePointer BaseType argument substitution by DebugInfoNone #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion nonsemantic/NonSemantic.Shader.DebugInfo.100.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,7 +614,8 @@ Describe a pointer or reference data type. +
{result_type} +
+
'Base Type' is the '<id>' of a debugging instruction that represents the pointee
type. +
type. If the 'Base Type' is not defined or not available in source program,
this operand must refer to <<DebugInfoNone,*DebugInfoNone*>>. +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that's your picked solution that is also implemented in the SPIR-V backend but I'd like to understand how this is preferable to the DebugTypeBasic trick as suggested in the thread #280 (comment)

I think DebugTypeBasic with FlagUnknownPhysicalLayout could be a suitable solution.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Naghasan I believe that answer #280 (comment) addresses your question. I'm open to further discussion.

+
'Storage Class' is a 32-bit integer *OpConstant* containing the class of the memory where
the object pointed to is allocated. Possible values of this operand are described in the
Expand Down
5 changes: 3 additions & 2 deletions nonsemantic/NonSemantic.Shader.DebugInfo.100.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1309,7 +1309,8 @@ <h3 id="_type_instructions">Type instructions</h3>
<em>Result Type</em> must be <strong>OpTypeVoid</strong>. <br>
<br>
<em>Base Type</em> is the <em>&lt;id&gt;</em> of a debugging instruction that represents the pointee
type.<br>
type. If the the <em>Base Type</em> is not specified or not available in source program, this operand must refer to
<a href="#DebugInfoNone"><strong>DebugInfoNone</strong></a>.<br>
<br>
<em>Storage Class</em> is a 32-bit integer <strong>OpConstant</strong> containing the class of the memory where
the object pointed to is allocated. Possible values of this operand are described in the
Expand Down Expand Up @@ -3323,4 +3324,4 @@ <h2 id="_revision_history">Revision History</h2>
</div>
</div>
</body>
</html>
</html>