Allow DebugTypePointer BaseType argument substitution by DebugInfoNone #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update addresses the DebugTypePointer instruction, which represents pointer types in the SPIR-V NonSemantic.Shader.DebugInfo.100 standard. Currently, the instruction requires a defined Base Type argument to comply with the standard. This requirement complicates the implementation of pointers to abstract types, such as void * in C, which represents type erasure, since these types do not have an available or defined Base Type. To accommodate such scenarios, the standard includes the DebugInfoNone instruction. This amendment allows for the substitution of the concrete Base Type argument in DebugTypePointer with DebugInfoNone, thereby simplifying the implementation process for abstract pointer types.
Naghasan
reviewed
Oct 23, 2024
| @@ -614,7 +614,8 @@ Describe a pointer or reference data type. + | |||
| {result_type} + | |||
| + | |||
| 'Base Type' is the '<id>' of a debugging instruction that represents the pointee | |||
| type. + | |||
| type. If the 'Base Type' is not defined or not available in source program, | |||
| this operand must refer to <<DebugInfoNone,*DebugInfoNone*>>. + | |||
There was a problem hiding this comment.
I understand that's your picked solution that is also implemented in the SPIR-V backend but I'd like to understand how this is preferable to the DebugTypeBasic trick as suggested in the thread #280 (comment)
I think DebugTypeBasic with FlagUnknownPhysicalLayout could be a suitable solution.
There was a problem hiding this comment.
@Naghasan I believe that answer #280 (comment) addresses your question. I'm open to further discussion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update addresses the DebugTypePointer instruction, which represents pointer types in the SPIR-V NonSemantic.Shader.DebugInfo.100 standard. Currently, the instruction requires a defined Base Type argument to comply with the standard. This requirement complicates the implementation of pointers to abstract types, such as void * in C, which represents type erasure, since these types do not have an available or defined Base Type.
To accommodate such scenarios, the standard includes the DebugInfoNone instruction. This amendment allows for the substitution of the concrete Base Type argument in DebugTypePointer with DebugInfoNone, thereby simplifying the implementation process for abstract pointer types.