-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: support build without git #3309
Merged
tisonkun
merged 4 commits into
GreptimeTeam:main
from
tisonkun:support_build_without_git
Feb 18, 2024
Merged
build: support build without git #3309
tisonkun
merged 4 commits into
GreptimeTeam:main
from
tisonkun:support_build_without_git
Feb 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <wander4096@gmail.com>
github-actions
bot
added
Size: M
docs-not-required
This change does not impact docs.
labels
Feb 18, 2024
tisonkun
commented
Feb 18, 2024
tisonkun
commented
Feb 18, 2024
tisonkun
requested review from
waynexia and
shuiyisong
and removed request for
waynexia
February 18, 2024 07:16
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3309 +/- ##
==========================================
- Coverage 85.51% 85.11% -0.41%
==========================================
Files 872 872
Lines 141944 141967 +23
==========================================
- Hits 121390 120831 -559
- Misses 20554 21136 +582 |
tisonkun
commented
Feb 18, 2024
shuiyisong
approved these changes
Feb 18, 2024
waynexia
approved these changes
Feb 18, 2024
b064f2c still fails:
|
shuiyisong
reviewed
Feb 18, 2024
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
force-pushed
the
support_build_without_git
branch
from
February 18, 2024 10:16
594a3fb
to
f320ff2
Compare
Signed-off-by: tison <wander4096@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This closes #3308.
However, this may cause building release sources loses metadata. I wonder if we fallback the meta loading from a file and generate that file on source release, or just use this fallback solution and wait until any issue report. cc @waynexia @shuiyisong @yurivict
Checklist
Refer to a related PR or issue link (optional)