-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should not use BuildInfo but rely on build time env #4331
Comments
I add this struct at 4e04a4e, while the previous usage is incorrect also. |
Possibly try use https://crates.io/crates/shadow-rs instead. And no more build-dependencies for all other crates. |
I can support in https://crates.io/crates/shadow-rs if possible |
@baoyachi thank you! I'll try it in days. Originally we make some changes because we'd support build without git, e.g., with a source tarball. I don't know if shadow-rs can populate unknown in such cases or just panic. The source code should tell but I'm yet to have time investigate it. |
@baoyachi I remembered why I stopped yesterday and why I suggest to use gix now ...
|
Maybe I'd upgrade substrait_proto to see if it can fix. Looks good now. Let me proceed. |
This comment was marked as resolved.
This comment was marked as resolved.
So here is the patch that I tested works locally - #4343 |
What type of bug is this?
Incorrect result
What subsystems are affected?
Standalone mode, Distributed Cluster
Minimal reproduce step
Running GreptimeDB in a brand new directory.
What did you expect to see?
We should return the build info, not fetch the info at runtime.
What did you see instead?
as above
What operating system did you use?
unrelated
What version of GreptimeDB did you use?
0030821
Relevant log output and stack trace
No response
The text was updated successfully, but these errors were encountered: