Fix selfdestruct empty vs. exists bug #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Can you reference some literature about this issue? Is this experimental or is it there a documented description about this behavior? |
LuisPH3
previously approved these changes
Oct 16, 2024
HerbertJordan
previously approved these changes
Oct 16, 2024
Here is the documentation inside the geth code and the related eip 161 |
simonlechner
dismissed stale reviews from HerbertJordan and LuisPH3
via
f952a5a
simonlechner
force-pushed
the
simon/selfdestruct-empty
branch
from
04fa7a9
to
f952a5a
Compare
simonlechner
force-pushed
the
simon/selfdestruct-empty
branch
from
f952a5a
to
7bdc44d
Compare
LuisPH3
approved these changes
Oct 17, 2024
LuisPH3
added a commit
that referenced
this pull request
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ethereum tests pointed out another problem regarding selfdestruct, the dynamic gas computation should not rely on whether the account exists but if its balance = 0, code = nil and nonce = 0.