-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix - Chat - Compose box stays in the middle when reduced with a several lines message #50520
Open
FitseTLT
wants to merge
24
commits into
Expensify:main
Choose a base branch
from
FitseTLT:fix-scroll-problem-on-composer-size-change
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
c7e3f5a
fix the bottom line of the composer on composer full size mode change
FitseTLT 26926f0
change listener
FitseTLT 447dc03
set prevHeight to content size height
FitseTLT 1792e20
resolve conflict
FitseTLT 2db9a48
Merge branch 'main' into fix-scroll-problem-on-composer-size-change
FitseTLT ccb9ca5
resolve conflict
FitseTLT dca3bcc
scroll to the cursor on composer size change for native
FitseTLT 9a62a08
Merge branch 'main' into fix-scroll-problem-on-composer-size-change
FitseTLT 6c80d07
Merge branch 'main' into fix-scroll-problem-on-composer-size-change
FitseTLT 54402d1
comment out the set selection code
FitseTLT 673c98c
Merge branch 'main' into fix-scroll-problem-on-composer-size-change
FitseTLT 4e65339
revert
FitseTLT aa8156d
only scroll to cursor on changing to composer to small size
FitseTLT 40c5968
Merge branch 'main' into fix-scroll-problem-on-composer-size-change
FitseTLT 913563b
fix tests
FitseTLT ff96f95
Merge branch 'main' into fix-scroll-problem-on-composer-size-change
FitseTLT d8076c1
applied small delay to setSelection
FitseTLT 295079f
reduced the delay
FitseTLT e873e25
Merge branch 'main' into fix-scroll-problem-on-composer-size-change
FitseTLT 4c1045a
Merge branch 'main' into fix-scroll-problem-on-composer-size-change
FitseTLT e226acf
Merge branch 'main' into fix-scroll-problem-on-composer-size-change
FitseTLT 624ab5f
Merge branch 'main' into fix-scroll-problem-on-composer-size-change
FitseTLT 1c3d327
Merge branch 'main' into fix-scroll-problem-on-composer-size-change
FitseTLT d80be2a
added comment
FitseTLT File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind putting a little more effort into this comment? We now have a great detailed explanation that should be easy to summarize. “We need the delay for setSelection to properly work for IOS” doesn’t really explain anything at all except that it's a platform workaround for some unknown issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry but we still don't know the correct root cause. can you suggest a comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah is there some kind of issue related to the bug that you can link? It sounds like we might be able to clean this up in the future.