Fix - Chat - Compose box stays in the middle when reduced with a several lines message #50520

FitseTLT · 2024-10-09T21:08:00Z

Details

Fixed Issues

$ #49541
PROPOSAL: #49541 (comment)

Tests

Open the staging.new.expensify.com website.
Open any chat.
On compose box, start writing a message adding new lines until a scrollbar can be seen.
Tap on the "Expand" button.
Keep adding lines to the message until a scrollbar can also be seen with the compose box expanded.
Reduce the compose box size.
Verify that the compose is scrolled to the bottom

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

2024-10-23.19-07-45.mp4

Android: mWeb Chrome

aw.mp4

iOS: Native

2024-10-23.18-47-28.mp4

iOS: mWeb Safari

iw.mp4

MacOS: Chrome / Safari

w.mp4

MacOS: Desktop

d.mp4

melvin-bot · 2024-10-09T21:08:05Z

@rayane-djouah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

FitseTLT · 2024-10-09T21:09:55Z

still working on native behaviour 👍

rayane-djouah · 2024-10-14T19:31:32Z

@FitseTLT Any update?

FitseTLT · 2024-10-15T13:11:52Z

@rayane-djouah, I am having difficulty scrolling the text input imperatively on native, unlike the web case. There is neither scrollTo function nor scrollTop prop to set on the ref. Do you have any suggestions?

rayane-djouah · 2024-10-17T11:01:50Z

Will check on my end and let you know

rayane-djouah · 2024-10-18T22:38:46Z

@FitseTLT The bug reported in #49541 (comment) is not reproducible on native platforms. Therefore, I believe we should maintain the current behavior for native.

FitseTLT · 2024-10-22T13:04:51Z

But @rayane-djouah I am seeing the same problem as the OP in IOS, for instance,

2024-10-22.16-03-05.mp4

rayane-djouah · 2024-10-23T00:14:59Z

Oh, so this bug is specific to iOS native? Then we need to find a solution for it.

FitseTLT · 2024-10-23T16:12:47Z

@rayane-djouah I have managed to scroll to cursor position, to indirectly solve the problem on native. Look at the results, I have now uploaded the native screenshots in OP, and let me know your opinion.

rayane-djouah · 2024-10-27T18:41:37Z

@FitseTLT Jest tests and performance tests are failing

rayane-djouah · 2024-11-01T19:27:14Z

@FitseTLT The solution is not working for me on iOS native:

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-11-01.at.20.23.04.mp4

FitseTLT · 2024-11-01T20:09:19Z

Fixed I suspect it is related with regression caused by the bridge less pr solved it by giving some delay

2024-11-01.23-03-11.mp4

src/components/Composer/implementation/index.native.tsx

FitseTLT · 2024-11-11T13:10:23Z

Hey @rayane-djouah I have been exploring how to programmatically scroll text inputs on natives and I found that we need to add scroll view for android, for instance, here

So I think there couldn't be any other workaround in react native and experimented the possibility of it but as you take the scrolling ability of the text input to the the scroll view you lose the auto grow behaviour of the text input and also there could be other side effects. Moreover, it wouldn't make sense to apply this kind of workaround considering the importance of the original bug.
It looks like I am running out of ideas now but fortunately, the problem only exists on IOS (assuming Android scrolls to the cursor by default) so I hand it to you for any decision on how to move forward. Thx!

rayane-djouah · 2024-11-15T11:29:21Z

@FitseTLT I will post an update today, could you please resolve the conflicts meanwhile? Thanks!

FitseTLT · 2024-11-15T21:44:32Z

@rayane-djouah resolved

rayane-djouah · 2024-11-20T17:31:22Z

@Expensify/design We've addressed the issue as detailed in this comment. However, due to platform constraints on iOS native, we're unable to directly align the scroll position to the bottom of the composer bar, it's always aligned to the top by default. As a workaround, we've implemented a solution to programmatically scroll the input, which introduces a scrolling animation. Could you please review the two videos comparing the behavior before and after the fix? We would like your feedback on whether the scrolling animation is acceptable.

Current iOS app behavior	Behavior after the fix
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-11-20.at.18.26.35.mp4	Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-11-20.at.18.29.15.mp4

dannymcclain · 2024-11-20T18:03:12Z

It feels a little teeny tiny bit weird to me, but I think I still prefer it over losing visibility of my cursor. Keen for the other designers to weigh in.

shawnborton · 2024-11-20T18:56:00Z

Yup, I agree with that. Feels like an improvement for sure though!

dubielzyk-expensify · 2024-11-21T03:21:31Z

Agree with you both

rayane-djouah · 2024-11-21T22:35:55Z

@FitseTLT There are merge conflicts

FitseTLT · 2024-11-21T22:41:02Z

Resolved @rayane-djouah

rayane-djouah

LGTM and tests well 👍

src/components/Composer/implementation/index.native.tsx

marcaaron · 2024-11-29T21:30:51Z

src/components/Composer/implementation/index.native.tsx

+            return;
+        }
+
+        // We need the delay for setSelection to properly work for IOS.


Mind putting a little more effort into this comment? We now have a great detailed explanation that should be easy to summarize. “We need the delay for setSelection to properly work for IOS” doesn’t really explain anything at all except that it's a platform workaround for some unknown issue.

I'm sorry but we still don't know the correct root cause. can you suggest a comment?

What about this?

// We need the delay for setSelection to properly work for IOS in bridgeless mode due to a react native internal bug of dispatching the event before the component is ready for it.

Yeah is there some kind of issue related to the bug that you can link? It sounds like we might be able to clean this up in the future.

FitseTLT added 3 commits October 9, 2024 22:54

fix the bottom line of the composer on composer full size mode change

c7e3f5a

change listener

26926f0

set prevHeight to content size height

447dc03

FitseTLT requested a review from a team as a code owner October 9, 2024 21:08

melvin-bot bot requested review from rayane-djouah and removed request for a team October 9, 2024 21:08

FitseTLT marked this pull request as draft October 9, 2024 21:08

resolve conflict

1792e20

FitseTLT added 2 commits October 22, 2024 16:01

Merge branch 'main' into fix-scroll-problem-on-composer-size-change

2db9a48

resolve conflict

ccb9ca5

FitseTLT added 2 commits October 23, 2024 18:47

scroll to the cursor on composer size change for native

dca3bcc

Merge branch 'main' into fix-scroll-problem-on-composer-size-change

9a62a08

FitseTLT added 7 commits October 27, 2024 22:26

Merge branch 'main' into fix-scroll-problem-on-composer-size-change

6c80d07

comment out the set selection code

54402d1

Merge branch 'main' into fix-scroll-problem-on-composer-size-change

673c98c

revert

4e65339

only scroll to cursor on changing to composer to small size

aa8156d

Merge branch 'main' into fix-scroll-problem-on-composer-size-change

40c5968

fix tests

913563b

FitseTLT marked this pull request as ready for review October 28, 2024 22:02

Merge branch 'main' into fix-scroll-problem-on-composer-size-change

ff96f95

FitseTLT added 2 commits November 1, 2024 23:00

applied small delay to setSelection

d8076c1

reduced the delay

295079f

rayane-djouah suggested changes Nov 2, 2024

View reviewed changes

src/components/Composer/implementation/index.native.tsx Outdated Show resolved Hide resolved

Merge branch 'main' into fix-scroll-problem-on-composer-size-change

e873e25

Merge branch 'main' into fix-scroll-problem-on-composer-size-change

4c1045a

Merge branch 'main' into fix-scroll-problem-on-composer-size-change

e226acf

FitseTLT requested a review from rayane-djouah November 21, 2024 22:21

Merge branch 'main' into fix-scroll-problem-on-composer-size-change

624ab5f

marcaaron assigned marcaaron and FitseTLT and unassigned marcaaron Nov 23, 2024

rayane-djouah approved these changes Nov 23, 2024

View reviewed changes

melvin-bot bot requested a review from marcaaron November 23, 2024 11:26

marcaaron requested changes Nov 25, 2024

View reviewed changes

src/components/Composer/implementation/index.native.tsx Show resolved Hide resolved

FitseTLT added 2 commits November 27, 2024 02:06

Merge branch 'main' into fix-scroll-problem-on-composer-size-change

1c3d327

added comment

d80be2a

FitseTLT requested a review from marcaaron November 29, 2024 21:07

marcaaron requested changes Nov 29, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix - Chat - Compose box stays in the middle when reduced with a several lines message #50520

Fix - Chat - Compose box stays in the middle when reduced with a several lines message #50520

FitseTLT commented Oct 9, 2024 •

edited

Loading

melvin-bot bot commented Oct 9, 2024

FitseTLT commented Oct 9, 2024

rayane-djouah commented Oct 14, 2024

FitseTLT commented Oct 15, 2024

rayane-djouah commented Oct 17, 2024

rayane-djouah commented Oct 18, 2024

FitseTLT commented Oct 22, 2024

rayane-djouah commented Oct 23, 2024

FitseTLT commented Oct 23, 2024

rayane-djouah commented Oct 27, 2024 •

edited

Loading

rayane-djouah commented Nov 1, 2024

FitseTLT commented Nov 1, 2024

FitseTLT commented Nov 11, 2024

rayane-djouah commented Nov 15, 2024

FitseTLT commented Nov 15, 2024

rayane-djouah commented Nov 20, 2024 •

edited

Loading

dannymcclain commented Nov 20, 2024

shawnborton commented Nov 20, 2024

dubielzyk-expensify commented Nov 21, 2024

rayane-djouah commented Nov 21, 2024

FitseTLT commented Nov 21, 2024

rayane-djouah left a comment

marcaaron Nov 29, 2024

FitseTLT Nov 29, 2024

FitseTLT Dec 2, 2024

marcaaron Dec 3, 2024

Fix - Chat - Compose box stays in the middle when reduced with a several lines message #50520

Are you sure you want to change the base?

Fix - Chat - Compose box stays in the middle when reduced with a several lines message #50520

Conversation

FitseTLT commented Oct 9, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 9, 2024

FitseTLT commented Oct 9, 2024

rayane-djouah commented Oct 14, 2024

FitseTLT commented Oct 15, 2024

rayane-djouah commented Oct 17, 2024

rayane-djouah commented Oct 18, 2024

FitseTLT commented Oct 22, 2024

rayane-djouah commented Oct 23, 2024

FitseTLT commented Oct 23, 2024

rayane-djouah commented Oct 27, 2024 • edited Loading

rayane-djouah commented Nov 1, 2024

FitseTLT commented Nov 1, 2024

FitseTLT commented Nov 11, 2024

rayane-djouah commented Nov 15, 2024

FitseTLT commented Nov 15, 2024

rayane-djouah commented Nov 20, 2024 • edited Loading

dannymcclain commented Nov 20, 2024

shawnborton commented Nov 20, 2024

dubielzyk-expensify commented Nov 21, 2024

rayane-djouah commented Nov 21, 2024

FitseTLT commented Nov 21, 2024

rayane-djouah left a comment

Choose a reason for hiding this comment

marcaaron Nov 29, 2024

Choose a reason for hiding this comment

FitseTLT Nov 29, 2024

Choose a reason for hiding this comment

FitseTLT Dec 2, 2024

Choose a reason for hiding this comment

marcaaron Dec 3, 2024

Choose a reason for hiding this comment

FitseTLT commented Oct 9, 2024 •

edited

Loading

rayane-djouah commented Oct 27, 2024 •

edited

Loading

rayane-djouah commented Nov 20, 2024 •

edited

Loading