Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(send): revamp send page layout #3254

Merged
merged 31 commits into from
Sep 27, 2023
Merged

Conversation

nistadev
Copy link
Contributor

First step
image

Second step
image
image

Second step modals
image
image

Third Step (footer WIP)
image
image

@nistadev nistadev requested a review from neuodev July 29, 2023 14:05
@neuodev
Copy link
Contributor

neuodev commented Jul 29, 2023

[autoscirpt] Jira Ticket: Send Page

@nistadev nistadev requested a review from vsubhuman July 29, 2023 14:05
@neuodev neuodev changed the title Feat/yoext 673/revamp send page feat(send): revamp send page layout Aug 1, 2023
@neuodev neuodev self-assigned this Aug 1, 2023
@neuodev neuodev marked this pull request as draft August 2, 2023 13:08
@neuodev
Copy link
Contributor

neuodev commented Aug 4, 2023

Screenshot 2023-08-04 at 6 18 45 AM

@neuodev neuodev requested a review from Nebyt August 4, 2023 08:12
@sonarqube-yoroi
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition D Reliability Rating on New Code (is worse than A)

See analysis details on SonarQube

Fix issues before they fail your Quality Gate with SonarLint SonarLint in your IDE.

@neuodev neuodev marked this pull request as ready for review August 7, 2023 09:28
@vsubhuman vsubhuman modified the milestones: 4.23.0, 5.0.0 Sep 18, 2023
Base automatically changed from feat/YOEXT-674/revamp-receive-page to develop September 25, 2023 05:39
vsubhuman and others added 4 commits September 25, 2023 08:52
…amp-send-page

# Conflicts:
#	packages/yoroi-extension/app/components/topbar/NavWalletDetailsRevamp.scss
#	packages/yoroi-extension/app/components/wallet/transactions/TransactionRevamp.js
#	packages/yoroi-extension/app/containers/wallet/MyWalletsPage.js
#	packages/yoroi-extension/app/containers/wallet/WalletSendPage.js
#	packages/yoroi-extension/package.json
…FormSteps/IncludedTokens.js

Co-authored-by: Patriciu Nista <patriciu.nista@gmail.com>
Copy link
Contributor

@neuodev neuodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🔥

@sonarqube-yoroi
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vsubhuman vsubhuman merged commit 3b5493c into develop Sep 27, 2023
9 of 21 checks passed
@vsubhuman vsubhuman deleted the feat/YOEXT-673/revamp-send-page branch September 27, 2023 16:55
@vsubhuman vsubhuman mentioned this pull request Oct 8, 2023
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants