Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve design system architecture and overall styling #3233

Merged
merged 20 commits into from
Sep 20, 2023

Conversation

nistadev
Copy link
Contributor

@nistadev nistadev commented Jun 14, 2023

Description

  • The architecture for the theming was improved to support multiple themes and to reuse styles for overriding components. This is the base for the future improvements regarding styles and theming across all application.
  • Removed gray backgrounds and layout paddings modified according to the new revamp specs (only affects revamp)
  • BONUS FEATURE: as I was changing the architecture for the theming part, in parallel I added a new theme we were working on with designers, dark theme. Still WIP but it is a good PoC and keeps the structure clean and simple, we will only need to be updatind the UI components to use DS tokens instead of hardcoded values or css-in-js properties. You will find a button to toggle the color mode on Settings > Version. Note: not all components are updated to use theming in a proper way, this will be done in the near future.

Screenshots
Overall design improvement (background, paddings)
image

(disabled) Dark mode
image

@nistadev nistadev requested review from Nebyt and neuodev June 14, 2023 07:05
@neuodev
Copy link
Contributor

neuodev commented Jun 14, 2023

@neuodev neuodev changed the title DS architecture improved, overall styles improved + bonus feat: design system architecture improved, overall styles improved Jun 14, 2023
@neuodev neuodev changed the title feat: design system architecture improved, overall styles improved feat: improve design system architecture and overall styling Jun 14, 2023
@nistadev nistadev requested a review from neuodev July 21, 2023 10:40
@neuodev neuodev self-assigned this Jul 24, 2023
@vsubhuman vsubhuman added this to the 4.23.0 milestone Jul 27, 2023
@nistadev
Copy link
Contributor Author

Fixed on the last commit 👇🏽

  • ✅ Buttons “Receive“ and “Send“ are missing
  • ✅ Border color of the wallet component is different from the design
  • ✅ The line-height of Export button should be 22 not 19 as it is now
  • ✅ Width of the left side-panel should be 72px.
  • ✅ The color of the left side-panel should be linear-gradient.
  • ✅ The icon for the Stake delegated is added to the design.
  • ✅ The width of the central part should be fixed to 1,872px

Fixed (or will be) in other PR 👇🏽

  • The copy address icon should have size 24x24 not 20x20 as it is now
  • The line-height of table headers should be 22 not 24 as it is now
  • The line-height of timestamp should be 22 not 24 as it is now
  • The height of the subMenu tabs element should be 48 not 37 as it is now

@neuodev neuodev marked this pull request as draft August 7, 2023 09:26
@neuodev neuodev marked this pull request as ready for review August 10, 2023 12:05
@neuodev neuodev marked this pull request as draft August 10, 2023 12:05
…YOEXT-600/add-style-variants-for-ds-components
@vsubhuman vsubhuman modified the milestones: 4.23.0, 5.0.0 Sep 11, 2023
@vsubhuman vsubhuman marked this pull request as ready for review September 18, 2023 10:08
@sonarqube-yoroi
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

@vsubhuman vsubhuman merged commit 4bbbb0c into develop Sep 20, 2023
6 of 12 checks passed
@vsubhuman vsubhuman deleted the feat/YOEXT-600/add-style-variants-for-ds-components branch September 20, 2023 14:15
@vsubhuman vsubhuman mentioned this pull request Oct 8, 2023
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants