slideshow: remove resolution adjustment - use the screen size #9792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eszkadev
reviewed
Aug 13, 2024
eszkadev
approved these changes
Aug 13, 2024
quikee
force-pushed
the
master
branch
2 times, most recently
from
2cf1531
to
0912eb6
Compare
mcecchetti
reviewed
Aug 13, 2024
| let resolutionWidth = 960; | ||
| let resolutionHeight = 540; | ||
|
|
||
| if (width > 1920 || height > 1080) { | ||
| resolutionWidth = 1920; | ||
| resolutionHeight = 1080; |
There was a problem hiding this comment.
That's fine to add new resolutions, but why removing FHD one ?
There was a problem hiding this comment.
This was not my intention
Previously we topped out at 1920x1080 resolution, which can become a problem for screens bigger than FHD, which are capable to show a much higher resolution of the slides but are artificially limited to a smaller resolution. This change adds 2560x1440 and 3840x2160 resolution. Ideally it would be to support resolution whatever the screen supports, but as there are issues with that (sliedshow does not show transitions correctly the second time) we add more options as a stop gap solution. Signed-off-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk> Change-Id: I9b132ad5ac897f956768c5d5a1e77fa18cb34246
|
Fixed the issues |
eszkadev
reviewed
Aug 14, 2024
| let resolutionWidth = 960; | ||
| let resolutionHeight = 540; | ||
|
|
||
| if (width > 1920 || height > 1080) { | ||
| if (width > 3840 || height > 2160) { |
There was a problem hiding this comment.
should be > -> >=, so 3840x2160 will be 3840x2160 in result, not 2560x1440
There was a problem hiding this comment.
That's not needed. tested width, height are multiplied by a 1.20 (see lines 190,191)
So 4K is used for whatever is greater than 3200x1800
Thanks! Looks fine to me now. |
mcecchetti
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we adjusted the resolution of the slides, so the size of the slide would be max 1920x1080. This restriction is removed now so the slide size can use the actual size of the screen. With this change the slides look much better on a high DPI screen (4k), but will also take longer to be transfered to the client as the size of the slides is bigger also.
Change-Id: I9b132ad5ac897f956768c5d5a1e77fa18cb34246
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay