Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slideshow: remove resolution adjustment - use the screen size #9792

Merged
merged 1 commit into from
Aug 14, 2024
Merged

slideshow: remove resolution adjustment - use the screen size #9792

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions browser/src/slideshow/LayersCompositor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,11 +189,16 @@ class LayersCompositor extends SlideShow.SlideCompositor {
public computeLayerResolution(width: number, height: number) {
eszkadev marked this conversation as resolved.
Show resolved Hide resolved
width *= 1.2;
height *= 1.2;

let resolutionWidth = 960;
let resolutionHeight = 540;

if (width > 1920 || height > 1080) {
if (width > 3840 || height > 2160) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be > -> >=, so 3840x2160 will be 3840x2160 in result, not 2560x1440

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not needed. tested width, height are multiplied by a 1.20 (see lines 190,191)
So 4K is used for whatever is greater than 3200x1800

resolutionWidth = 3840;
resolutionHeight = 2160;
} else if (width > 2560 || height > 1440) {
resolutionWidth = 2560;
resolutionHeight = 1440;
} else if (width > 1920 || height > 1080) {
resolutionWidth = 1920;
resolutionHeight = 1080;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine to add new resolutions, but why removing FHD one ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not my intention

} else if (width > 1280 || height > 720) {
Expand Down
Loading