feat(InventoryMove): no inventory interactions while moving #4728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1zun4
reviewed
Nov 30, 2024
Comment on lines
-245
to
-248
|
|
||
| if (screen is InventoryScreen) { | ||
| isInventoryOpenServerSide = true | ||
| } |
There was a problem hiding this comment.
I'm a little bit worried about this. I have to validate first if this is not causing any issues with the Inventory Manager
There was a problem hiding this comment.
As I thought:
Inventory Cleaner and other modules will not try to change the items anymore when inventory is opened. It always requires one click to trigger it to be open. But I can easily fix this.
There was a problem hiding this comment.
Alright, I didn't consider that. I changed it because the server only knows that we're in an inventory if we click a slot.
|
I cannot push to your PR: |
|
I have prepared a fix for this, but will delay it until the 0.22.0 release instead. |
|
I have created a pull request for you to merge: Zirada#2 |
refactor: fix code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New InventoryMove mode where you can't interact with the inventory while moving. This should be undetectable.