Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic Circuit recipe should only output IC2 circuits #1580

Open
wants to merge 4 commits into
base: unstable
Choose a base branch
from
Open

Basic Circuit recipe should only output IC2 circuits #1580

wants to merge 4 commits into from

Commits on Oct 19, 2020

  1. Merge pull request #1 from Blood-Asp/unstable 

    Syncing from original.
    @MauveCloud
    MauveCloud authored Oct 19, 2020
    Configuration menu
    Copy the full SHA
    be6c573 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2020

  1. Refactoring, plus circuit recipe 

    Added some category methods so the run() method is less vulnerable to error messages about being too big.
Added specific crafting recipe for IC2 circuit (see Blood-Asp#1574).
    @MauveCloud
    MauveCloud authored Oct 28, 2020
    Configuration menu
    Copy the full SHA
    01dfb3f View commit details
    Browse the repository at this point in the history

  2. Removed generic "basicCircuit" crafting recipe. 

    If loading sequence caused another mod's "basicCircuit" to be registered after IC2's, then that would be the only one craftable, making the GT good circuit uncraftable.
    @MauveCloud
    MauveCloud authored Oct 28, 2020
    Configuration menu
    Copy the full SHA
    937dfd0 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2020

  1. Reverted refactoring. 

    Realized it was a bad idea to do this in the same PR as other changes.
    @MauveCloud
    MauveCloud committed Nov 1, 2020
    Configuration menu
    Copy the full SHA
    5115e5c View commit details
    Browse the repository at this point in the history