Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear buffers before preloading first section #1009

Merged
merged 1 commit into from
May 14, 2024
Merged

Clear buffers before preloading first section #1009

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions frontend/src/components/Preload/Preload.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,11 @@ const Preload = ({ sections, playMethod, duration, preloadMessage, pageTitle, on
}
return;
}

// Clear buffers if this is the first section
if (index === 0) {
webAudio.clearBuffers();
}

// Load sections in buffer
return webAudio.loadBuffer(section.id, section.url, () => {
Expand All @@ -66,8 +71,6 @@ const Preload = ({ sections, playMethod, duration, preloadMessage, pageTitle, on
}

preloadResources();
// on destroy, clean up buffers
return webAudio.clearBuffers();
}, [sections, playMethod, onNext]);

return (
Expand Down
Loading