Clear buffers before preloading first section #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1006
The
webAudio.clearBuffers()function was moved in #1003 to act as the cleanup function for the react hook it's in.When preloading a section that was also used in the previous turn, the preloading of the section was skipped by
webAudio.checkSectionLoaded()after which the buffers were cleared on cleanup and there was nothing to play, which caused the experiment to freeze.Putting the
webAudio.clearBuffers()back in place solved the problem.As most experiments only use 1 section per round the
webAudio.clearBuffers()was meant to prevent the loaded buffers from taking up to much memory: Otherwise if there were 30 rounds with unique sections, all 30 buffers would remain in memory untill the experiment was finished, which could cause problems.I made some further suggestions to improve performance in issue #1008