Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproducable dev environments with devbox #159

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

niklasbeinghaus
Copy link

  • Add devbox
  • Use devbox for testing
  • Add devbox to the CI pipeline

see: #8

- Add devbox
- Use devbox for testing
- Add devbox to the CI pipeline

Signed-off-by: njoerd114 <njoerd@cccfr.de>
@drbacke
Copy link
Contributor

drbacke commented Oct 11, 2024

I don't know devbox. No idea what it does or if it's helpfull here. Maybe someone else can look at it?

@BerndCzech
Copy link
Collaborator

BerndCzech commented Oct 11, 2024

I did not know it before and I can see why people recommend it.

What confused me was the devbox.lock file but this is intentional (point 5.)

Imho contribution.md or readme.md could use a first script instruction to validate the contribution, e.g. use devbox run test to calidate your contribution etc.

@niklasbeinghaus
Copy link
Author

Imho contribution.md or readme.md could use a first script instruction to validate the contribution, e.g. use devbox run test to calidate your contribution etc.

the github-ci includes the test run, so there is already a validation...

@drbacke drbacke marked this pull request as draft October 22, 2024 08:52
@drbacke
Copy link
Contributor

drbacke commented Oct 22, 2024

Please re-run all tests, code changed quite a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants