Over The Air device config feature #48
Conversation
|
hell ya. lmk when you'd like a review :) |
|
Yup will ping you in a bit! |
t-sasatani
changed the title
t-sasatani
changed the title
t-sasatani
force-pushed
the
feature_ir_update
branch
from
b0cafee
to
a9ead50
Compare
|
@sneakers-the-rat I'd appreciate it if you could have a look. I'm mostly unsure what a good way to test device I/O is. |
|
Added some tests that cover device I/Os (might be a bit too manual) and docs for the hardware. Docs are very minimal but should be good for now. |
There was a problem hiding this comment.
Some suggestions on error messages, but overall i'd be fine with merging this as long as we raise an issue to remind us to write a full mock of the Serial device later. I would really prefer we stick to python naming conventions and use snake case for function names, but don't want to be a dictator about it.
Other than that, hopefully comments are self explanatory
sneakers-the-rat
force-pushed
the
feature_ir_update
branch
from
9c35f5b
to
b913814
Compare
|
oh crap sorry i hit rebase and forgot that it adds me as co-author on all the commits :'\. should have waited for u |
|
Thanks for the comments! I'll look into it in a bit. And the commits are no problem; I'm not sure if I can interact with origin this week anyway. |
Co-authored-by: Jonny Saunders <JLSaunders987@gmail.com>
Co-authored-by: Jonny Saunders <JLSaunders987@gmail.com>
Co-authored-by: Jonny Saunders <JLSaunders987@gmail.com>
| @@ -74,7 +74,9 @@ def validate_values(cls, values: dict) -> dict: | |||
| elif target in UpdateTarget: | |||
| raise NotImplementedError() | |||
| else: | |||
| raise ValueError(f"{target} is not a valid update target, need an instance of UpdateTarget") | |||
| raise ValueError( | |||
| f"{target} is not a valid update target," "need an instance of UpdateTarget" | |||
There was a problem hiding this comment.
this happens to me literally all the time where i want to split a line for aesthetic reasons and then black is like "no you should not have split that line." it borders on malicious compliance and i imagine black having a smile on its face every time it does this like "you were the one who set the line width!"
There was a problem hiding this comment.
Oh, I was fully trusting black and wasn't even paying attention to the changes it made lol. Didn't know it was making my code ugly!
There was a problem hiding this comment.
i think it is literally equivalent to the interpreter after parsing (?), but at the same time there is something bad about ("start " "end") vs "start end" that feels like the machines are taking revenge when they make it happen.
This PR adds modules and CLI to update device parameters over the air.
To-dos
Add more commands
Tests
Others/low priority
Integrate with the capture command(Future work)Check metadata and validate device update (plotting and checking by eye might be good for now)(Future work)