Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scalable method for defining device update commands #70

Open
t-sasatani opened this issue Nov 11, 2024 · 1 comment
Open

Scalable method for defining device update commands #70

t-sasatani opened this issue Nov 11, 2024 · 1 comment

Comments

@t-sasatani
Copy link
Collaborator

#48 added downlink commands, but the command set is still hard-coded and complicated to expand. We should unify the command set (related: #48 (comment)), or maybe feed them using the device config. Using device config might be better because the available peripherals and bounds of the values vary between devices, which seems relatively easy to handle with a nested YAML file.

@t-sasatani t-sasatani changed the title Scalable method for adding device commands Scalable method for defining device update commands Nov 11, 2024
@sneakers-the-rat
Copy link
Collaborator

Agreed. This is part of the API refactor (which im realizing I should have done separately from the pipelining system, but so it goes) - each device will have a configure method that takes an instance of that device's DeviceConfig. So we will want to do a few things to make that possible, also described in other issues

  • make a user config directory
  • commands for generating/copying default configs as a starting point that can then be modified
  • IDs for configs so we can do something like mio configure MyDevice rather than needing to refer to a path

Then we can also have cli for setting specific options like mio configure MyDevice fps=30 or whatever that both sets the value on the device and sets it in the config file so they stay sync'd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants