Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sourcery refactored status-nested branch #4

Open
wants to merge 1 commit into
base: status-nested
Choose a base branch
from
Open

Sourcery refactored status-nested branch #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions gendiff/comparator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,10 @@
# * Fixed WPS441, WPS440 to allow variable names to be reused in multiple loops
# * https://github.com/wemake-services/wemake-python-styleguide/pull/1768#pullrequestreview-550906165 # noqa:E501
def compile_diff(first_data_set, second_data_set):
diff = {}
keys_intersection = first_data_set.keys() & second_data_set.keys()
for data_key in keys_intersection:
diff[data_key] = compare_same_keys(
diff = {data_key: compare_same_keys(
first_data_set.get(data_key), second_data_set.get(data_key),
)
) for data_key in keys_intersection}
Comment on lines -18 to +21
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function compile_diff refactored with the following changes:

keys_removed = first_data_set.keys() - second_data_set.keys()
for data_key in keys_removed: # noqa:WPS440
diff[data_key] = {STATUS: REMOVED, VALUE: first_data_set.get(data_key)} # noqa:WPS441, E501
Expand Down