Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sourcery refactored status-nested branch #4

Open
wants to merge 1 commit into
base: status-nested
Choose a base branch
from

Conversation

sourcery-ai[bot]
Copy link

@sourcery-ai sourcery-ai bot commented Jan 24, 2021

Branch status-nested refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the status-nested branch, then run:

git fetch origin sourcery/status-nested
git merge --ff-only FETCH_HEAD
git reset HEAD^

@sourcery-ai sourcery-ai bot requested a review from AABur January 24, 2021 18:53
Comment on lines -18 to +21
diff = {}
keys_intersection = first_data_set.keys() & second_data_set.keys()
for data_key in keys_intersection:
diff[data_key] = compare_same_keys(
diff = {data_key: compare_same_keys(
first_data_set.get(data_key), second_data_set.get(data_key),
)
) for data_key in keys_intersection}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function compile_diff refactored with the following changes:

@sourcery-ai
Copy link
Author

sourcery-ai bot commented Jan 24, 2021

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 1.44%.

Quality metrics Before After Change
Complexity 2.08 ⭐ 1.58 ⭐ -0.50 👍
Method Length 51.33 ⭐ 50.00 ⭐ -1.33 👍
Working memory 6.15 ⭐ 6.00 ⭐ -0.15 👍
Quality 81.53% 82.97% 1.44% 👍
Other metrics Before After Change
Lines 30 28 -2
Changed files Quality Before Quality After Quality Change
gendiff/comparator.py 81.53% ⭐ 82.97% ⭐ 1.44% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants